New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 670407 link

Starred by 1 user
Status: Fixed
Owner:
qiangchen@chromium.org
Closed: Jan 2017
Cc:
braveyao@chromium.org
█ roc...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Desktop Capture Failure When Audio Checkbox Is Unchecked

Project Member Reported by qiangchen@chromium.org, Dec 1 2016 
Desktop capture will fail if by design it intends to do audio share, but the user unchecks the audio share checkbox.

The reason is that getUserMedia will fail if the caller requests audio that we cannot provide.

So the solution is that we return the audio share information to the caller, so that the caller can react correctly based on it.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ec1ad9cf69edcb08db2237ddb1b4b4f293491ab

commit 9ec1ad9cf69edcb08db2237ddb1b4b4f293491ab
Author: qiangchen <qiangchen@chromium.org>
Date: Wed Dec 14 00:11:48 2016

Desktop Capture API: Pass Audio Selection Information To Javascript

The API mediaDevices.getUserMedia will throw an exception if the caller
requests audio but we cannot provide.

Here is the situation for desktop capture, the user could uncheck the
audio check box, and thus revoke the audio share. But the current
setting of chooseDesktopMedia does not pass this piece of information
to Javascript, which will put the caller into a dilemma whether to
request audio or not in getUserMedia call.

BUG= 670407 

Review-Url: https://codereview.chromium.org/2547633002
Cr-Commit-Position: refs/heads/master@{#438351}

[modify] https://crrev.com/9ec1ad9cf69edcb08db2237ddb1b4b4f293491ab/chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
[modify] https://crrev.com/9ec1ad9cf69edcb08db2237ddb1b4b4f293491ab/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/9ec1ad9cf69edcb08db2237ddb1b4b4f293491ab/chrome/common/extensions/api/desktop_capture.json
[modify] https://crrev.com/9ec1ad9cf69edcb08db2237ddb1b4b4f293491ab/chrome/common/extensions/docs/examples/api/desktopCapture/app.js
[modify] https://crrev.com/9ec1ad9cf69edcb08db2237ddb1b4b4f293491ab/chrome/renderer/resources/extensions/desktop_capture_custom_bindings.js
[modify] https://crrev.com/9ec1ad9cf69edcb08db2237ddb1b4b4f293491ab/chrome/test/data/extensions/api_test/desktop_capture/test.js

Comment 2 by qiangchen@chromium.org, Jan 6 2017

Status: Fixed (was: Started)
►

Sign in to add a comment