New issue
Advanced search Search tips

Issue 670400 link

Starred by 1 user
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

remoting/host/token_validator_base.cc doesn't handle some network errors correctly.

Project Member Reported by mmenke@chromium.org, Dec 1 2016 
On network errors before headers are received, it hands.  When reading the response body of a request, if the first read of a response body returns 0 bytes (i.e., and empty response body), and this is discovered synchronously, the request also hangs.

I noticed this while auditing URLRequest::Delegates for a small API change.  I have a fix these issues which I'll send out for review when I update the API.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7

commit 94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7
Author: mmenke <mmenke@chromium.org>
Date: Wed Dec 07 21:13:05 2016

ResourceLoader:  Fix a bunch of double-cancellation/double-error notification cases.

There are a number of cases where ResourceLoader ends up notifying ResourceHandlers
twice of the same failure. This CL fixes them and adds some tests.

It also makes URLRequest no longer post notification on sync read errors, which was
causing double notifications in one of those cases.

Also fixes two other URLRequest consumers that depended on that behavior.

BUG= 669709 , 670400 

Review-Url: https://codereview.chromium.org/2542843006
Cr-Commit-Position: refs/heads/master@{#437057}

[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/content/browser/cache_storage/cache_storage_blob_to_disk_cache.cc
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/content/browser/loader/intercepting_resource_handler_unittest.cc
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/content/browser/loader/resource_loader.h
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/content/browser/loader/resource_loader_unittest.cc
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/content/browser/loader/test_resource_handler.cc
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/content/browser/loader/test_resource_handler.h
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/net/url_request/url_request.cc
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/net/url_request/url_request_job.cc
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/net/url_request/url_request_job.h
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/net/url_request/url_request_test_job.cc
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/net/url_request/url_request_test_job.h
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/net/url_request/url_request_test_util.cc
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/net/url_request/url_request_test_util.h
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/remoting/host/token_validator_base.cc
[modify] https://crrev.com/94f1bd9459e17972e8e3f6f51a3d10fbf4a94df7/remoting/host/token_validator_factory_impl_unittest.cc

Comment 2 by mmenke@chromium.org, Dec 7 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment