CSS Motion Path: Don't report motion* properties as deprecated yet |
||||||||
Issue descriptionWait until we have offset-rotate before deprecating motion* For more details of the proposed plan see goo.gl/XFvGR8
,
Dec 2 2016
Request merge for https://codereview.chromium.org/2540333003 (Ignore the third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-floats-crash-2... changes as that test post-dates M55.)
,
Dec 2 2016
M55 for Desktop is already in Stable and bar is extremely high to take any merges in. Can this wait until M56? Also seems like change landed after M56 branch, please request a merge to M56 if needed. Thank you.
,
Dec 2 2016
> Can this wait until M56? The problem is that we would be reporting a deprecation for motion-rotation etc. when the replacement isn't ready yet: there was an extremely recent decision to rename offset-rotation to offset-rotate, and so offset-rotate can't be in M55.
,
Dec 2 2016
Thank you ericwilligers@. + amineer@ to take his input as well on merge as change is applicable to all OS.
,
Dec 3 2016
[Automated comment] Less than 2 weeks to go before stable on M55, manual review required.
,
Dec 5 2016
Chatted with amineer. It would be expensive to retest all the mobile devices. If we can merge this only for the benefit of desktop, that will already be great.
,
Dec 6 2016
Merge approved for M55 branch 2883. As we may not respin Android in time to pick up the merge, +dknox@ to help get our supporting documentation updated to address the inconsistency.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fea1a727fa96ac7f6e525225e07724ff0534cba9 commit fea1a727fa96ac7f6e525225e07724ff0534cba9 Author: Eric Willigers <ericwilligers@chromium.org> Date: Tue Dec 06 00:42:10 2016 Revert "CSS Motion Path: report use of deprecated motion* properties" This reverts commit c49a0a4cd2d0cbb1a42fdb7d22540139058592ff. We need to wait with the deprecation message until we are shipping offset-rotate. BUG= 670390 Review-Url: https://codereview.chromium.org/2540333003 Cr-Commit-Position: refs/heads/master@{#435804} (cherry picked from commit 6e75a0e7f22d36666ac2157c6ffef0aded35d822) Review URL: https://codereview.chromium.org/2549343002 . Cr-Commit-Position: refs/branch-heads/2924@{#350} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [delete] https://crrev.com/adb80b7795001c20ab8fbd84dedfebeeafedb6f5/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt [delete] https://crrev.com/adb80b7795001c20ab8fbd84dedfebeeafedb6f5/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated.html [delete] https://crrev.com/adb80b7795001c20ab8fbd84dedfebeeafedb6f5/third_party/WebKit/LayoutTests/css3/motion-path/motion-shorthand-deprecated-expected.txt [delete] https://crrev.com/adb80b7795001c20ab8fbd84dedfebeeafedb6f5/third_party/WebKit/LayoutTests/css3/motion-path/motion-shorthand-deprecated.html [modify] https://crrev.com/fea1a727fa96ac7f6e525225e07724ff0534cba9/third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-floats-crash-2-expected.txt [modify] https://crrev.com/fea1a727fa96ac7f6e525225e07724ff0534cba9/third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-floats-crash-2.html [modify] https://crrev.com/fea1a727fa96ac7f6e525225e07724ff0534cba9/third_party/WebKit/Source/core/frame/Deprecation.cpp
,
Dec 6 2016
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d9bf10adc492d6aeda4a9d60d41a836ff7c73bb commit 0d9bf10adc492d6aeda4a9d60d41a836ff7c73bb Author: Eric Willigers <ericwilligers@chromium.org> Date: Tue Dec 06 01:51:42 2016 Revert "CSS Motion Path: report use of deprecated motion* properties" This reverts commit c49a0a4cd2d0cbb1a42fdb7d22540139058592ff. We need to wait with the deprecation message until we are shipping offset-rotate. BUG= 670390 Review-Url: https://codereview.chromium.org/2540333003 Cr-Commit-Position: refs/heads/master@{#435804} (cherry picked from commit 6e75a0e7f22d36666ac2157c6ffef0aded35d822) Review URL: https://codereview.chromium.org/2553603003 . Cr-Commit-Position: refs/branch-heads/2883@{#712} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [delete] https://crrev.com/34ca308256952476dbf2519fbe7d70d40a942142/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt [delete] https://crrev.com/34ca308256952476dbf2519fbe7d70d40a942142/third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated.html [delete] https://crrev.com/34ca308256952476dbf2519fbe7d70d40a942142/third_party/WebKit/LayoutTests/css3/motion-path/motion-shorthand-deprecated-expected.txt [delete] https://crrev.com/34ca308256952476dbf2519fbe7d70d40a942142/third_party/WebKit/LayoutTests/css3/motion-path/motion-shorthand-deprecated.html [modify] https://crrev.com/0d9bf10adc492d6aeda4a9d60d41a836ff7c73bb/third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-floats-crash-2-expected.txt [modify] https://crrev.com/0d9bf10adc492d6aeda4a9d60d41a836ff7c73bb/third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-floats-crash-2.html [modify] https://crrev.com/0d9bf10adc492d6aeda4a9d60d41a836ff7c73bb/third_party/WebKit/Source/core/frame/Deprecation.cpp |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 2 2016