Issue metadata
Sign in to add a comment
|
1.6%-22.2% regression in memory.top_10_mobile_stress at 434943:434996 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Dec 1 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8994454588275494656
,
Dec 1 2016
=== PERF REGRESSION === === Auto-CCing suspected CL author machenbach@chromium.org === Hi machenbach@chromium.org, the bisect results pointed to your CL, please take a look at the results. ===== BISECT JOB RESULTS ===== Status: failed === Bisection aborted === The bisect was aborted because Failed to upload result to Perf Dashboard. Error response: 500 Please contact the the team (see below) if you believe this is in error. ===== SUSPECTED CL(s) ===== Subject : Revert of [ic] Use validity cells to protect keyed element stores against object's prototype chain modificati… (patchset #2 id:40001 of https://codereview.chromium.org/2534613002/ ) Author : machenbach Commit description: Reason for revert: Layout test crashes: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11691 Original issue's description: > [ic] Use validity cells to protect keyed element stores against object's prototype chain modifications. > > ... instead of clearing of all the KeyedStoreICs which didn't always work. > > BUG= chromium:662907 , v8:5561 > TBR=verwaest@chromium.org, bmeurer@chromium.org > > Committed: https://crrev.com/a39522f44f7e0be4686831688917e9675255dcaf > Cr-Commit-Position: refs/heads/master@{#41332} TBR=jkummerow@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= chromium:662907 , v8:5561 Review-Url: https://codereview.chromium.org/2538693002 Cr-Commit-Position: refs/heads/master@{#41337} Commit : 9c0e2a6723e3f4ea1c181d235a08b1115663d39a Date : Tue Nov 29 08:49:48 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@434961 5245203 312055 8 good chromium@434974 5201009 14903.9 8 good chromium@434978 5244333 312268 8 good chromium@434978,v8@18eda7024b 5259275 432289 12 good chromium@434978,v8@1e3c5c90cd 5230617 320165 12 good chromium@434978,v8@9c0e2a6723 5201436 7040.53 12 bad <-- chromium@434978,v8@4e7571a5a9 6304643 3951.88 5 bad chromium@434979 6307459 888.007 5 bad chromium@434980 6307016 2677.58 5 bad chromium@434981 6305589 3290.45 5 bad chromium@434987 6374946 309782 5 bad Bisect job ran on: android_nexus9_perf_bisect Bug ID: 670366 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.m.intl.taobao.com.group.purchase.html memory.top_10_mobile_stress Test Metric: memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/background/after_http_m_intl_taobao_com_group_purchase_html Relative Change: 21.54% Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/2299 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8994454588275494656 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=4510570080894976 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Dec 1 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8994435951810010480
,
Dec 2 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : [ic] Use validity cells to protect keyed element stores against object's prototype chain modifications. Author : ishell Commit description: ... instead of clearing of all the KeyedStoreICs which didn't always work. BUG= chromium:662907 , v8:5561 TBR=verwaest@chromium.org, bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2534613002 Cr-Commit-Position: refs/heads/master@{#41332} Commit : a39522f44f7e0be4686831688917e9675255dcaf Date : Mon Nov 28 22:56:52 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@434961 5200776 11821.9 8 good chromium@434974 5201912 5956.76 8 good chromium@434978 5203066 4850.33 18 good chromium@434978,v8@a39522f44f 5215978 342206 27 bad <-- chromium@434978,v8@bc1a3820c2 5203435 6041.95 18 bad chromium@434978,v8@18eda7024b 5203880 173.436 5 bad chromium@434978,v8@4e7571a5a9 6304496 4082.49 5 bad chromium@434979 6374261 309835 5 bad chromium@434980 6305571 3211.43 5 bad chromium@434981 6306069 3312.84 5 bad chromium@434987 6305549 3296.34 5 bad Bisect job ran on: android_nexus9_perf_bisect Bug ID: 670366 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.m.intl.taobao.com.group.purchase.html memory.top_10_mobile_stress Test Metric: memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/background/after_http_m_intl_taobao_com_group_purchase_html Relative Change: 21.24% Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/2300 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8994454588275494656 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=4510570080894976 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Dec 5 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lanwei@chromium.org
, Dec 1 2016