New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670358 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename PageLoad.AbortTiming to PageLoad.Experimental.AbortTiming.

Project Member Reported by bmcquade@chromium.org, Dec 1 2016

Issue description

PageLoad.AbortTiming metrics have 'This metric is still experimental and not
yet ready to be relied upon.' in their description, but don't use the more
recent PageLoad metrics convention of being named starting with
PageLoad.Experimental. They should be renamed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fd2976e2f214a191d46d3714d3a688efdc8fc31

commit 2fd2976e2f214a191d46d3714d3a688efdc8fc31
Author: bmcquade <bmcquade@chromium.org>
Date: Fri Dec 02 01:50:36 2016

Rename PageLoad.AbortTiming to PageLoad.Experimental.AbortTiming.

PageLoad.AbortTiming metrics have 'This metric is still experimental and not
yet ready to be relied upon.' in their description, but don't use the more
recent PageLoad metrics convention of being named starting with
PageLoad.Experimental. This change fixes that.

The existing PageLoad.AbortTiming metrics have a number of issues, as described
in
https://docs.google.com/document/d/1pH3LYp_Obt0gbM9qCLd6woH7TvaAV6Sma5xw--wXcQ0/edit.

We'll be making changes to these metrics as we try to improve them. To make it
clearer that these metrics aren't yet stable and shouldn't be depended on, this
change renames all PageLoad.AbortTiming.* metrics to
PageLoad.Experimental.AbortTiming.*. Once the experimental metrics stabilize,
we'll establish new trusted metrics in the PageLoad.AbortTiming namespace.

BUG= 670358 

Review-Url: https://codereview.chromium.org/2542023003
Cr-Commit-Position: refs/heads/master@{#435818}

[modify] https://crrev.com/2fd2976e2f214a191d46d3714d3a688efdc8fc31/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
[modify] https://crrev.com/2fd2976e2f214a191d46d3714d3a688efdc8fc31/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/2fd2976e2f214a191d46d3714d3a688efdc8fc31/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
[modify] https://crrev.com/2fd2976e2f214a191d46d3714d3a688efdc8fc31/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Untriaged)

Sign in to add a comment