AndroidScrollIntegrationTest#testUiScrollReflectedInJs failing on lots of devices
Reported by
kra...@amazon.com,
Dec 1 2016
|
||||||||
Issue descriptionChrome Version: Tip of master OS: Android What steps will reproduce the problem? (1) Run AndroidScrollIntegrationTest#testUiScrollReflectedInJs on a Fire HD 8" (2016 model) or one of many other devices What is the expected result? The test passes What happens instead? C 820.205s Main junit.framework.AssertionFailedError: Criteria not met in allotted time. C 820.205s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74) C 820.205s Main at org.chromium.android_webview.test.AwTestBase.pollInstrumentationThread(AwTestBase.java:523) C 820.205s Main at org.chromium.android_webview.test.AndroidScrollIntegrationTest.assertScrollInJs(AndroidScrollIntegrationTest.java:263) C 820.205s Main at org.chromium.android_webview.test.AndroidScrollIntegrationTest.testUiScrollReflectedInJs(AndroidScrollIntegrationTest.java:345) C 820.205s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 820.205s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 820.206s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 820.206s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 820.206s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 820.206s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 820.206s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 820.206s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:557) C 820.206s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1874) Please use labels and text to provide additional information. This change started with the following commit, and no longer occurs when reverting that commit: https://codereview.chromium.org/2511473003 Looking at the exact numbers on a Fire HD 8 (2016), the actual and expected values seem to be off by one pixel (rounding errors?) I didn't test the other devices this is failing on, but I expect it to also be 1 pixel. Full list of failing devices we test this on (and this should be expected to fail on many more Android devices): - Fire HD 8" (2016 model) - Fire HD 8" (2015 model, which has different hardware than the 2016 one) - Fire HD 7" (2014 model)
,
Dec 5 2016
We're not seeing similar failures on our bots, though they're a narrow subset of Android devices and do not include any Fire devices at this time. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=android_webview_test_apk&tests=AndroidScrollIntegrationTest%23testUiScrollReflectedInJs timav: looks like you were the last person to modify this test. Can you take a look at this?
,
Dec 5 2016
I think it's because many Fire devices have relatively rare aspect ratios and DIP scales. We've definitely had similar issues in the past, e.g.: https://bugs.chromium.org/p/chromium/issues/detail?id=537343 https://bugs.chromium.org/p/chromium/issues/detail?id=647719 If you're okay with solving it in a similar fashion as before (allow rounding errors of 1px), I'd be happy to post a CL. I just wasn't sure whether or not that was the preferred approach since this was caused by a recent change.
,
Aug 18 2017
,
Aug 31 2017
kraush@, is this still an issue? I think allowing rounding errors is acceptable to fix the test. Adding boliu@ since he reviewed the Cl mentioned in the description.
,
Sep 1 2017
test probably should try to duplicate the rounding behavior that cc is doing, not just blindly allow rounding errors
,
Sep 4 2017
The assigned owner "timav@chromium.org" is not able to receive e-mails, please re-triage. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5 2017
This isn't critical, anyone can take this up. We'll gladly review a fix along the lines proposed in c#6.
,
Sep 6
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 17
I think this is not actionable right now since we don't have a device could repro the test failure, we probably need to know the DIP and other necessary parameters in this test to figure out why it is failing. From other related issues, the DIP is 1.3312500715255737, which I don't believe we could handle it precisely since we are using float type everywhere. Given the original reporter didn't reply for almost two years, we probably should close this one. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ajha@chromium.org
, Dec 2 2016Labels: M-57 OS-Android