Skia roll suspected of causing failures on multiple bots |
||
Issue descriptione.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/27239 has https://chromium.googlesource.com/chromium/src/+/749c5466102850a151448c59d99be6cffffc0bf5 in the blamelist. svg/dynamic-updates/SVGImageElement-dom-x-attr.html svg/custom/js-update-image-and-display3.svg svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html svg/custom/js-update-image-and-display2.svg svg/dynamic-updates/SVGImageElement-dom-width-attr.html images/paint-subrect.html paint/invalidation/svg/animated-path-inside-transformed-html.xhtml css3/blending/background-blend-mode-image-image.html svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html paint/invalidation/svg/js-update-image.svg svg/custom/js-update-image-and-display.svg svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html css3/blending/background-blend-mode-different-image-formats.html virtual/mojo-loading/http/tests/local/file-url-sent-as-referer.html svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html svg/custom/createImageElement2.xhtml svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html virtual/gpu-rasterization/images/paint-subrect.html virtual/rootlayerscrolls/scrollbars/listbox-scrollbar-combinations.html svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html svg/custom/use-on-g-containing-foreignObject-and-image.svg svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox.svg svg/custom/image-small-width-height.svg svg/custom/text-image-opacity.svg svg/dynamic-updates/SVGImageElement-dom-y-attr.html svg/custom/createImageElement.svg Except for the mojo-loading one, these look like rasterization differences, so the Skia roll seems a likely culprit. Assigning to brianosman@, Skia sheriff. Stopped roller, going to revert the roll and see if it helps.
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8ad7b81c26b2c03433f40dcbf7e8b0709e22644 commit e8ad7b81c26b2c03433f40dcbf7e8b0709e22644 Author: jbroman <jbroman@chromium.org> Date: Thu Dec 01 17:52:36 2016 Revert of Roll src/third_party/skia/ 71b762f2a..1c038af27 (3 commits). (patchset #1 id:1 of https://codereview.chromium.org/2542133002/ ) Reason for revert: speculative revert to fix https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/27239 Original issue's description: > Roll src/third_party/skia/ 71b762f2a..1c038af27 (3 commits). > > https://skia.googlesource.com/skia.git/+log/71b762f2aca1..1c038af278a6 > > $ git log 71b762f2a..1c038af27 --date=short --no-merges --format='%ad %ae %s' > 2016-12-01 reed Revert "Revert "remove (empty) SkXfermode.h"" > 2016-12-01 halcanary No SkEncodeImageAsKTX for ANDROID_FRAMEWORK > 2016-11-30 msarett SkColorSpaceXform bug fixes > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, see: > http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > TBR=brianosman@google.com > > Committed: https://crrev.com/749c5466102850a151448c59d99be6cffffc0bf5 > Cr-Commit-Position: refs/heads/master@{#435626} TBR=brianosman@google.com,skia-deps-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 670347 Review-Url: https://codereview.chromium.org/2537303006 Cr-Commit-Position: refs/heads/master@{#435645} [modify] https://crrev.com/e8ad7b81c26b2c03433f40dcbf7e8b0709e22644/DEPS
,
Dec 1 2016
Revert seems to have made at least one of these bots go green so far: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/9436
,
Dec 1 2016
We've reverted the SkColorSpaceXform CL, for this (and other) reasons, so it should be safe to re-start the roller.
,
Dec 1 2016
Turned the roller back on.
,
Jan 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by jbroman@chromium.org
, Dec 1 2016