New issue
Advanced search Search tips

Issue 670343 link

Starred by 1 user
Status: Fixed
Owner:
petewil@chromium.org
Closed: Dec 2016
Cc:
dougarnett@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Create 2 more tasks for RequestQueue.

Project Member Reported by fgor...@chromium.org, Dec 1 2016 
Split Picker Task and Clean up Task

So that we can do the clean up work independently and get to a cleaner picker task.

Create a Consistency Check Task

This is to ensure we reconcile the state of the requests after Chrome restart. Should be scheduled/run right after Initialization task.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55fc16c382cd559fca177abd0ae291213bd5893b

commit 55fc16c382cd559fca177abd0ae291213bd5893b
Author: petewil <petewil@chromium.org>
Date: Tue Dec 06 19:03:51 2016

Split the RequestPicker task into two separate tasks.

We still have a picker task, but now we also have a cleanup task.  The
cleanup task will remove expired entries, and entries that exceed their
start or completion limit.  It does not yet flip offlining tasks to
available on startup, I plan that for a separate changelist, and likely
a new task.

BUG= 670343 

Review-Url: https://codereview.chromium.org/2543093002
Cr-Commit-Position: refs/heads/master@{#436671}

[modify] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/BUILD.gn
[add] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/cleanup_task.cc
[add] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/cleanup_task.h
[add] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/cleanup_task_factory.cc
[add] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/cleanup_task_factory.h
[add] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/cleanup_task_unittest.cc
[add] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/offliner_policy_utils.cc
[add] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/offliner_policy_utils.h
[modify] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/pick_request_task.cc
[modify] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/pick_request_task.h
[delete] https://crrev.com/0428d2791da252d73049587ac6bd4fa1610f6734/components/offline_pages/background/pick_request_task_factory.cc
[delete] https://crrev.com/0428d2791da252d73049587ac6bd4fa1610f6734/components/offline_pages/background/pick_request_task_factory.h
[modify] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/pick_request_task_unittest.cc
[modify] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/request_coordinator_unittest.cc
[modify] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/request_queue.cc
[modify] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/request_queue.h
[modify] https://crrev.com/55fc16c382cd559fca177abd0ae291213bd5893b/components/offline_pages/background/request_queue_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18352e92d55f65f7bc986a535f797f5e5e52b69f

commit 18352e92d55f65f7bc986a535f797f5e5e52b69f
Author: petewil <petewil@chromium.org>
Date: Fri Dec 16 21:22:14 2016

Reconcile the request queue on startup.

If Chromium dies while an offline request is active, when we start back
up, the request will be in the "OFFLINING" state in the request queue.
However, unless it is in the AVAILABLE state, it will not be a candidate
for either cleanup or re-starting.  So, this change adds a fix when
the request coordinator first starts for every run changes requests
left in the OFFLINING state to the AVAILABLE state.

BUG= 670343 

Review-Url: https://codereview.chromium.org/2568613002
Cr-Commit-Position: refs/heads/master@{#439190}

[modify] https://crrev.com/18352e92d55f65f7bc986a535f797f5e5e52b69f/components/offline_pages/core/background/BUILD.gn
[modify] https://crrev.com/18352e92d55f65f7bc986a535f797f5e5e52b69f/components/offline_pages/core/background/cleanup_task.cc
[add] https://crrev.com/18352e92d55f65f7bc986a535f797f5e5e52b69f/components/offline_pages/core/background/reconcile_task.cc
[add] https://crrev.com/18352e92d55f65f7bc986a535f797f5e5e52b69f/components/offline_pages/core/background/reconcile_task.h
[add] https://crrev.com/18352e92d55f65f7bc986a535f797f5e5e52b69f/components/offline_pages/core/background/reconcile_task_unittest.cc
[modify] https://crrev.com/18352e92d55f65f7bc986a535f797f5e5e52b69f/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/18352e92d55f65f7bc986a535f797f5e5e52b69f/components/offline_pages/core/background/request_coordinator.h
[modify] https://crrev.com/18352e92d55f65f7bc986a535f797f5e5e52b69f/components/offline_pages/core/background/request_queue.cc
[modify] https://crrev.com/18352e92d55f65f7bc986a535f797f5e5e52b69f/components/offline_pages/core/background/request_queue.h

Comment 3 by petewil@chromium.org, Dec 17 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment