Improve MediaSession routing |
||
Issue descriptionWe should update the implementation w.r.t. latest discussions on https://github.com/WICG/mediasession/issues/136
,
Dec 6 2016
,
Dec 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f5596e8dcfd88ba7700393dd937eafb9ea39167 commit 7f5596e8dcfd88ba7700393dd937eafb9ea39167 Author: zqzhang <zqzhang@chromium.org> Date: Mon Dec 19 16:27:47 2016 [MediaSession] A fix for MediaSessionService routing Previously, MediaSessionImpl uses the metadata and controls to determine whether a page uses the MediaSession API. However there comes an issues that we need to update the routed MediaSession every time when a service is created/destroyed or its metadata/controls changed, which is a lot of maintainance work. This CL simplifies the MediaSessionService routing strategy. It only checks whether a service is created for a given frame. The rationale is that a MediaSessionService is created when and only when anything passes through mojo, which is enough for indicating whether a frame uses MediaSession API. BUG= 670319 Review-Url: https://codereview.chromium.org/2585243002 Cr-Commit-Position: refs/heads/master@{#439488} [modify] https://crrev.com/7f5596e8dcfd88ba7700393dd937eafb9ea39167/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/7f5596e8dcfd88ba7700393dd937eafb9ea39167/content/browser/media/session/media_session_impl_browsertest.cc [modify] https://crrev.com/7f5596e8dcfd88ba7700393dd937eafb9ea39167/content/browser/media/session/media_session_impl_service_routing_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Dec 5 2016