New issue
Advanced search Search tips

Issue 670307 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 567358



Sign in to add a comment

virtual/threaded/http/tests/worklet/animation-worklet-import.html crashes

Project Member Reported by jbroman@chromium.org, Dec 1 2016

Issue description

Mac, Linux Leak.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded%2Fhttp%2Ftests%2Fworklet%2Fanimation-worklet-import.html&testType=webkit_tests

Sample crash stack:

[32976:14339:1201/065342.729298:16180856645468:FATAL:weak_ptr.cc(26)] Check failed: sequence_checker_.CalledOnValidSequence(). WeakPtrs must be checked on the same sequenced thread.
0   Content Shell Framework             0x000000010e07c9a3 base::debug::StackTrace::StackTrace() + 19
1   Content Shell Framework             0x000000010e09fb47 logging::LogMessage::~LogMessage() + 71
2   Content Shell Framework             0x000000010e0b1db7 base::internal::WeakReference::is_valid() const + 119
3   Content Shell Framework             0x000000011148d890 blink::ThreadedWorkletObjectProxy::reportConsoleMessage(blink::MessageSource, blink::MessageLevel, WTF::String const&, blink::SourceLocation*) + 48
4   Content Shell Framework             0x00000001110223b4 blink::WorkerThreadDebugger::exceptionThrown(blink::WorkerThread*, blink::ErrorEvent*) + 84
5   Content Shell Framework             0x000000011148c98e blink::ThreadedWorkletGlobalScope::exceptionThrown(blink::ErrorEvent*) + 158
6   Content Shell Framework             0x0000000110a21151 blink::ExecutionContext::dispatchErrorEvent(blink::ErrorEvent*, blink::AccessControlStatus) + 225
7   Content Shell Framework             0x00000001101f8a89 blink::WorkerOrWorkletScriptController::evaluate(blink::ScriptSourceCode const&, blink::ErrorEvent**, blink::CachedMetadataHandler*, blink::V8CacheOptions) + 985
8   Content Shell Framework             0x000000011148d100 blink::(anonymous namespace)::evaluateScriptOnWorkletGlobalScope(WTF::String const&, blink::KURL const&, blink::ExecutionContext*) + 192
9   Content Shell Framework             0x00000001112929f0 blink::internal::CallClosureTask<void (blink::ExecutionContext*), (WTF::FunctionThreadAffinity)0>::performTask(blink::ExecutionContext*) + 32
10  Content Shell Framework             0x00000001114a3b5a blink::WorkerThread::performTaskOnWorkerThread(std::__1::unique_ptr<blink::ExecutionContextTask, std::__1::default_delete<blink::ExecutionContextTask> >, bool) + 362
11  Content Shell Framework             0x00000001114a8a6e base::internal::Invoker<base::internal::BindState<void (blink::WorkerThread::*)(std::__1::unique_ptr<blink::ExecutionContextTask, std::__1::default_delete<blink::ExecutionContextTask> >, bool), WTF::UnretainedWrapper<blink::WorkerThread, (WTF::FunctionThreadAffinity)0>, WTF::PassedWrapper<std::__1::unique_ptr<blink::ExecutionContextTask, std::__1::default_delete<blink::ExecutionContextTask> > >, bool>, void ()>::Run(base::internal::BindStateBase*) + 62
12  Content Shell Framework             0x000000010e07d0c1 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 225
13  Content Shell Framework             0x000000010e0b5e19 base::MessageLoop::RunTask(base::PendingTask*) + 425
14  Content Shell Framework             0x000000010e0b61dc base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 44
15  Content Shell Framework             0x000000010e0b66d3 base::MessageLoop::DoWork() + 467
16  Content Shell Framework             0x000000010e0ba717 base::MessagePumpCFRunLoopBase::RunWork() + 55
17  Content Shell Framework             0x000000010e0a08ba base::mac::CallWithEHFrame(void ( block_pointer)()) + 10
18  Content Shell Framework             0x000000010e0ba0e4 base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 68
19  CoreFoundation                      0x00007fff85810881 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
20  CoreFoundation                      0x00007fff857effbc __CFRunLoopDoSources0 + 556
21  CoreFoundation                      0x00007fff857ef4df __CFRunLoopRun + 927
22  CoreFoundation                      0x00007fff857eeed8 CFRunLoopRunSpecific + 296
23  Content Shell Framework             0x000000010e0bac4f base::MessagePumpCFRunLoop::DoRun(base::MessagePump::Delegate*) + 79
24  Content Shell Framework             0x000000010e0ba567 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 119
25  Content Shell Framework             0x000000010e0b5b62 base::MessageLoop::RunHandler() + 354
26  Content Shell Framework             0x000000010e0e71f3 base::RunLoop::Run() + 51
27  Content Shell Framework             0x000000010e12b7a7 base::Thread::Run(base::RunLoop*) + 199
28  Content Shell Framework             0x000000010e12bd16 base::Thread::ThreadMain() + 854
29  Content Shell Framework             0x000000010e12238f base::(anonymous namespace)::ThreadFunc(void*) + 95
30  libsystem_pthread.dylib             0x00007fff95fa399d _pthread_body + 131
31  libsystem_pthread.dylib             0x00007fff95fa391a _pthread_body + 0
32  libsystem_pthread.dylib             0x00007fff95fa1351 thread_start + 13

Looks like WeakPtr is being used in a way that isn't thread-safe. Will land a CL to skip this for now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/709bed6fb6118447395fa2fde5e36795b5e93218

commit 709bed6fb6118447395fa2fde5e36795b5e93218
Author: jbroman <jbroman@chromium.org>
Date: Thu Dec 01 15:43:50 2016

Skip virtual/threaded/http/tests/worklet/animation-worklet-import.html.

It crashes due to a WeakPtr SequenceChecker failure.

BUG= 670307 
TBR=ikilpatrick@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2549533002
Cr-Commit-Position: refs/heads/master@{#435617}

[modify] https://crrev.com/709bed6fb6118447395fa2fde5e36795b5e93218/third_party/WebKit/LayoutTests/TestExpectations

Cc: ikilpatrick@chromium.org
Owner: nhiroki@chromium.org
(Blink-Worker bug triage) I'll triage this.
Status: Started (was: Assigned)
I cannot reproduce this on my local builds. Let me enable this again and monitor the dashboard.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc272fcee054fe36d29911452c64957e092c9079

commit fc272fcee054fe36d29911452c64957e092c9079
Author: nhiroki <nhiroki@chromium.org>
Date: Fri Feb 17 07:12:17 2017

Worklet: Enable virtual/threaded/http/tests/worklet/animation-worklet-import.html again

I cannot reproduce this failure on my local builds. Let me enable this again and
check if this still happens.

BUG= 670307 
TBR=nhiroki@chromium.org

Review-Url: https://codereview.chromium.org/2702553004
Cr-Commit-Position: refs/heads/master@{#451258}

[modify] https://crrev.com/fc272fcee054fe36d29911452c64957e092c9079/third_party/WebKit/LayoutTests/TestExpectations

Labels: M-58
Status: WontFix (was: Started)
Looks like the test is now correctly working. Let me mark this as WONTFIX.

Sign in to add a comment