New issue
Advanced search Search tips

Issue 670291 link

Starred by 2 users
Status: Fixed
Owner:
hs1217....@samsung.com
Closed: Dec 2016
Cc:
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: 57-Stable
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----

Blocking:
issue 587995



Sign in to add a comment

PaymentComplete result "unknown"

Project Member Reported by rouslan@chromium.org, Dec 1 2016 
(See http://www.chromium.org/blink#launch-process for an overview)

Changes to API surface:
* Replace the PaymentComplete enum value "" with the more descriptive "unknown".

Links:
https://github.com/w3c/browser-payment-api/pull/312/files
https://w3c.github.io/browser-payment-api/#dom-paymentcomplete

Support in other browsers:
Edge: No public signals
Firefox: Public support
Safari: No public signals
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae2f34d94bd078c054c17a25b0bfe5f896f7316b

commit ae2f34d94bd078c054c17a25b0bfe5f896f7316b
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Fri Dec 02 04:32:16 2016

[PaymentRequest] Replace '' with 'unknown' in PaymentComplete.

Replace the PaymentComplete enum value "" with the more descriptive "unknown".

Intent to implement:
 https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/B-8p5Ji-O9Q/nrkDOHHgBAAJ

related spec list:
 https://github.com/w3c/browser-payment-api/pull/312
 https://w3c.github.io/browser-payment-api/#dom-paymentcomplete

BUG= 670291 

Review-Url: https://codereview.chromium.org/2537493003
Cr-Commit-Position: refs/heads/master@{#435857}

[modify] https://crrev.com/ae2f34d94bd078c054c17a25b0bfe5f896f7316b/third_party/WebKit/Source/modules/payments/PaymentResponse.idl

Comment 2 by rouslan@chromium.org, Dec 2 2016

Cc: foolip@chromium.org
Status: Fixed (was: Assigned)
The change turned out to be imperceptible to web developers. According to the spec, any unspecified value used to behave like "" and now behaves like "unknown", which have identical meaning. Therefore, it's not possible to hide the feature behind a runtime flag. So it's shipped in M-57.
►

Sign in to add a comment