New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 670277 link

Starred by 1 user
Status: Archived
Owner:
█ pihsun@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
█ youcheng@chromium.org
marcochen@chromium.org
█ shunhsingou@chromium.org
conradlo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Factory: End-to-end touch support

Project Member Reported by hungte@chromium.org, Dec 1 2016 
Chrome Version: ToT
OS: Chrome

What steps will reproduce the problem?
(1) Build factory UI for a Chromebook with touchscreen
(2) Try to complete factory flow with simply touch screen

What is the expected result?
Finish the factory flow without problems.

What happens instead?
Does not work. Few tests uses BindKey and expects keystrokes; some hotkeys (like the key for engineering mode) are hard-coded in Goofy. Some keys were made in JavaScript.

For devices with touch interface, it's more natural for operators to use touch screen directly instead of relying on keyboard inputs.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/f52fde97509871def22a54d12e8fa4812e81e629

commit f52fde97509871def22a54d12e8fa4812e81e629
Author: Peter Shih <pihsun@chromium.org>
Date: Fri Dec 02 07:12:05 2016

goofy: add toggle engineering mode to menu item

So we can enter engineering mode by touch screen only.

BUG= chromium:670277 
TEST=make test

Change-Id: I6d077c34485725ed604ce0b363951c3f1dbe0965
Reviewed-on: https://chromium-review.googlesource.com/415654
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[modify] https://crrev.com/f52fde97509871def22a54d12e8fa4812e81e629/py/goofy/js/goofy.js
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/55231c685ed5e69e1ec7ba30a4a5bed289c5d1fa

commit 55231c685ed5e69e1ec7ba30a4a5bed289c5d1fa
Author: Peter Shih <pihsun@chromium.org>
Date: Fri Dec 02 07:40:07 2016

goofy: add onscreen link to cancel pending shutdown

so we can cancel pending shutdown by touchscreen only.

BUG= chromium:670277 
TEST=make test

Change-Id: Ie1fd23afa714c4ea54c461c3b0d91a031e8fa47d
Reviewed-on: https://chromium-review.googlesource.com/416029
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[modify] https://crrev.com/55231c685ed5e69e1ec7ba30a4a5bed289c5d1fa/py/goofy/js/goofy.js
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/f958c7db104940002371ef65a04ab8455ef697c2

commit f958c7db104940002371ef65a04ab8455ef697c2
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Dec 05 05:23:13 2016

test: remove unused template.BindStandardKeys()

Reverts CL:32123, since this function is never used by anyone, and we'll
probably need the place for virtual keys on screen in touch screen UI.

BUG= chromium:670277 
TEST=make test

Change-Id: I19cd587ec0a3d7b1e5dc9349e303f636f2cef139
Reviewed-on: https://chromium-review.googlesource.com/416469
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[modify] https://crrev.com/f958c7db104940002371ef65a04ab8455ef697c2/py/goofy/static/ui_templates/template_one_scrollable_section.html
[modify] https://crrev.com/f958c7db104940002371ef65a04ab8455ef697c2/py/goofy/static/ui_templates/template_two_sections.html
[modify] https://crrev.com/f958c7db104940002371ef65a04ab8455ef697c2/py/goofy/static/ui_templates/template_one_section.html
[modify] https://crrev.com/f958c7db104940002371ef65a04ab8455ef697c2/py/test/ui_templates.py
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/392f595c9dc11d85c785a2cd074fc3b65629f06c

commit 392f595c9dc11d85c785a2cd074fc3b65629f06c
Author: Peter Shih <pihsun@chromium.org>
Date: Wed Dec 07 08:55:46 2016

test: enforce tests to use BindKey instead of custom JS

So we can have an unified interface for registering key binding, and can
hook BindKey to add on-screen touch support for key binding later.

BUG= chromium:670277 
TEST=make test

Change-Id: I8a66de60498502e8d1933064499f7428310b49dc
Reviewed-on: https://chromium-review.googlesource.com/416030
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/audio_loop/audio_loop.js
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/audio_basic.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/ethernet.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/audio_quality_static/audio_quality.js
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/audio_loop/audio_loop.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/camera_fixture_static/camera_fixture.js
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/recovery_button.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/start/start.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/test_ui.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/buzzer.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/camera_fixture.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/check_image_version.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/touchscreen_calibration/touchscreen_calibration.html
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/accelerometers_lid_angle.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/touchscreen_calibration/touchscreen_calibration.js
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/touchscreen_calibration/touchscreen_calibration.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/light_sensor.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/vpd_from_http.py
[modify] https://crrev.com/392f595c9dc11d85c785a2cd074fc3b65629f06c/py/test/pytests/audio_quality.py
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/850b792a7f17abb2eed64b04ff8ab515c57af648

commit 850b792a7f17abb2eed64b04ff8ab515c57af648
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Dec 08 09:33:13 2016

test: rework pytest display_point challenge response

The old way to respond to challenge in display_point pytest is using a
text input, which would need a virtual keyboard to be popped out if we
want to use touchscreen only. But the virtual keyboard would interfere
with the following fullscreen test.

Since we probably never want to have challenge of more than 10 points
(default is 3), a single number keypress is enough for challenge
response. This makes using touchscreen only easier.

This also simplify the process of answering. Assuming that the answers
are 2 and 3.
Keystrokes to pass old test:
  [Space] [Space] 2 [Enter] [Space] 3 [Enter]
Keystrokes to pass new test:
  [Space] 2 3

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: Ia3bfbfa2812572a6c638940af0ba747e14307788
Reviewed-on: https://chromium-review.googlesource.com/417683
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/850b792a7f17abb2eed64b04ff8ab515c57af648/py/test/pytests/display_point.py
[modify] https://crrev.com/850b792a7f17abb2eed64b04ff8ab515c57af648/py/test/pytests/display_point_static/display_point.js
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/455abc3ce06ad0db80147f48cbde8c1a323c2ad3

commit 455abc3ce06ad0db80147f48cbde8c1a323c2ad3
Author: Peter Shih <pihsun@chromium.org>
Date: Tue Dec 13 07:24:46 2016

test: fix can't finish pytest audio_quality on touchscreen only

The test is not using standard templates, so we have to add a
virtualkey-button-container to HTML manually.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: Ie30d86a8911f3a9a992afe6ce377c56c96191ced
Reviewed-on: https://chromium-review.googlesource.com/418428
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/455abc3ce06ad0db80147f48cbde8c1a323c2ad3/py/test/pytests/audio_quality_static/audio_quality.html
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/b252ddbd721221882b5cd8482a56f449eb17fa24

commit b252ddbd721221882b5cd8482a56f449eb17fa24
Author: Peter Shih <pihsun@chromium.org>
Date: Tue Dec 13 08:36:18 2016

test: improve UI of pytest camera when using touchscreen only.

In led_manual, the code bind 0~9 when only using 0 and 1. Also,
capture_manual bind enter and esc each frame, causing the buttons to be
repeated added. Fix both.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I5b2ae09403cdbebfd314ae7acaf7e02e5cc003da
Reviewed-on: https://chromium-review.googlesource.com/418520
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/b252ddbd721221882b5cd8482a56f449eb17fa24/py/test/factory_task.py
[modify] https://crrev.com/b252ddbd721221882b5cd8482a56f449eb17fa24/py/test/pytests/camera.py
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/f5320f72571f8ec88a79cb0db4c5105e95f17fc9

commit f5320f72571f8ec88a79cb0db4c5105e95f17fc9
Author: Peter Shih <pihsun@chromium.org>
Date: Fri Dec 09 04:37:36 2016

pytest: Fix pytest audio doesn't work well on touchscreen only

There are some BindKey that's called multiple times across multiple
runs, causing the buttons to appear twice. Remove all key bindings on
FactoryTask._Finish.

Also don't bind ENTER in InteractiveFactoryTask.BindPassFailKeys if
pass_key=False.

Also fix a bug that javascript keycode is always uppercase, thus binding
lowercase characters doesn't work.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I12d7fae39ca361ec8cd4eacab970defb79277f11
Reviewed-on: https://chromium-review.googlesource.com/418536
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/f5320f72571f8ec88a79cb0db4c5105e95f17fc9/py/test/pytests/audio.py
[modify] https://crrev.com/f5320f72571f8ec88a79cb0db4c5105e95f17fc9/py/test/factory_task.py
[modify] https://crrev.com/f5320f72571f8ec88a79cb0db4c5105e95f17fc9/py/test/test_ui.py
[modify] https://crrev.com/f5320f72571f8ec88a79cb0db4c5105e95f17fc9/py/goofy/js/goofy.js
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 19 2016

Labels: merge-merged-factory-oak-8182.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/28e58b3e49458e2aee5b0d5c3acf8ea668fa0f84

commit 28e58b3e49458e2aee5b0d5c3acf8ea668fa0f84
Author: Peter Shih <pihsun@chromium.org>
Date: Fri Dec 02 07:12:05 2016

CHERRY-PICK: goofy: add toggle engineering mode to menu item

So we can enter engineering mode by touch screen only.

BUG= chromium:670277 
TEST=make test

Change-Id: I6d077c34485725ed604ce0b363951c3f1dbe0965
Reviewed-on: https://chromium-review.googlesource.com/415654
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/421375
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[modify] https://crrev.com/28e58b3e49458e2aee5b0d5c3acf8ea668fa0f84/py/goofy/js/goofy.js
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/77a024d403afe8333745b79285eb10bac4503dea

commit 77a024d403afe8333745b79285eb10bac4503dea
Author: Peter Shih <pihsun@chromium.org>
Date: Fri Dec 02 07:40:07 2016

CHERRY-PICK: goofy: add onscreen link to cancel pending shutdown

so we can cancel pending shutdown by touchscreen only.

BUG= chromium:670277 
TEST=make test

Change-Id: Ie1fd23afa714c4ea54c461c3b0d91a031e8fa47d
Reviewed-on: https://chromium-review.googlesource.com/416029
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/421376
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[modify] https://crrev.com/77a024d403afe8333745b79285eb10bac4503dea/py/goofy/js/goofy.js
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/de9fa7abf1306406d527e6868e1717b74cd1e2dc

commit de9fa7abf1306406d527e6868e1717b74cd1e2dc
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Dec 05 05:23:13 2016

CHERRY-PICK: test: remove unused template.BindStandardKeys()

Reverts CL:32123, since this function is never used by anyone, and we'll
probably need the place for virtual keys on screen in touch screen UI.

BUG= chromium:670277 
TEST=make test

Change-Id: I19cd587ec0a3d7b1e5dc9349e303f636f2cef139
Reviewed-on: https://chromium-review.googlesource.com/416469
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/421377
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[modify] https://crrev.com/de9fa7abf1306406d527e6868e1717b74cd1e2dc/py/goofy/static/ui_templates/template_one_scrollable_section.html
[modify] https://crrev.com/de9fa7abf1306406d527e6868e1717b74cd1e2dc/py/goofy/static/ui_templates/template_two_sections.html
[modify] https://crrev.com/de9fa7abf1306406d527e6868e1717b74cd1e2dc/py/goofy/static/ui_templates/template_one_section.html
[modify] https://crrev.com/de9fa7abf1306406d527e6868e1717b74cd1e2dc/py/test/ui_templates.py
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/0ba1eb0cf6c8a455af01553f92bceac654f60c07

commit 0ba1eb0cf6c8a455af01553f92bceac654f60c07
Author: Peter Shih <pihsun@chromium.org>
Date: Wed Dec 07 08:55:46 2016

CHERRY-PICK: test: enforce tests to use BindKey instead of custom JS

So we can have an unified interface for registering key binding, and can
hook BindKey to add on-screen touch support for key binding later.

BUG= chromium:670277 
TEST=make test

Change-Id: I8a66de60498502e8d1933064499f7428310b49dc
Reviewed-on: https://chromium-review.googlesource.com/416030
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@google.com>
Reviewed-on: https://chromium-review.googlesource.com/421378
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/audio_loop/audio_loop.js
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/audio_basic.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/ethernet.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/audio_quality_static/audio_quality.js
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/audio_loop/audio_loop.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/camera_fixture_static/camera_fixture.js
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/recovery_button.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/start/start.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/test_ui.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/buzzer.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/camera_fixture.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/check_image_version.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/touchscreen_calibration/touchscreen_calibration.html
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/accelerometers_lid_angle.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/touchscreen_calibration/touchscreen_calibration.js
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/touchscreen_calibration/touchscreen_calibration.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/light_sensor.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/vpd_from_http.py
[modify] https://crrev.com/0ba1eb0cf6c8a455af01553f92bceac654f60c07/py/test/pytests/audio_quality.py
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/f63ce83e1687d20dc1f01c3fb457fe9215a50297

commit f63ce83e1687d20dc1f01c3fb457fe9215a50297
Author: Peter Shih <pihsun@chromium.org>
Date: Wed Dec 07 08:56:35 2016

CHERRY-PICK: test: fix some test doesn't work well with touch screen only

Some tests require keyboard to exit full-screen mode, change them to
also accept a click on screen to exit full-screen mode.

BUG= chromium:670277 
TEST=make test

Change-Id: Ia038e235eb9a09a9cce4bcf0a501cacf7cc8c3dd
Reviewed-on: https://chromium-review.googlesource.com/417423
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/421379
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[modify] https://crrev.com/f63ce83e1687d20dc1f01c3fb457fe9215a50297/py/test/pytests/display_point.py
[modify] https://crrev.com/f63ce83e1687d20dc1f01c3fb457fe9215a50297/py/test/pytests/display_idle_static/display_idle.js
[modify] https://crrev.com/f63ce83e1687d20dc1f01c3fb457fe9215a50297/py/test/pytests/display_point_static/display_point.js
[modify] https://crrev.com/f63ce83e1687d20dc1f01c3fb457fe9215a50297/py/test/pytests/display.py
[modify] https://crrev.com/f63ce83e1687d20dc1f01c3fb457fe9215a50297/py/test/pytests/display_idle.py
[modify] https://crrev.com/f63ce83e1687d20dc1f01c3fb457fe9215a50297/py/test/pytests/display_static/display.js
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/056db0ed29810139efcb329ba0876f910bdede42

commit 056db0ed29810139efcb329ba0876f910bdede42
Author: Peter Shih <pihsun@chromium.org>
Date: Wed Dec 07 06:41:16 2016

CHERRY-PICK: test: add virtual key buttons on screen when BindKey

Add buttons on screen for keyboard operations, to better support using
touch screen only for factory testing.

BUG= chromium:670277 
TEST=make test

Change-Id: If08298ce5f2409e857d245049ae0101905c60173
Reviewed-on: https://chromium-review.googlesource.com/417720
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/421380
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>
Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org>
Tested-by: Hsu Wei-Cheng <mojahsu@chromium.org>

[modify] https://crrev.com/056db0ed29810139efcb329ba0876f910bdede42/py/goofy/static/ui_templates/template.css
[modify] https://crrev.com/056db0ed29810139efcb329ba0876f910bdede42/py/test/test_ui.py
[modify] https://crrev.com/056db0ed29810139efcb329ba0876f910bdede42/py/goofy/static/ui_templates/template_one_scrollable_section.html
[modify] https://crrev.com/056db0ed29810139efcb329ba0876f910bdede42/py/goofy/static/ui_templates/template_one_section.html
[modify] https://crrev.com/056db0ed29810139efcb329ba0876f910bdede42/py/goofy/static/ui_templates/template_two_sections.html
[modify] https://crrev.com/056db0ed29810139efcb329ba0876f910bdede42/py/goofy/js/goofy.js

Comment 18 by marcochen@chromium.org, Jan 9 2017

Cc: marcochen@chromium.org
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/2cb4fc746f946a71d9831ef9741df1fc8594a695

commit 2cb4fc746f946a71d9831ef9741df1fc8594a695
Author: Peter Shih <pihsun@chromium.org>
Date: Tue Dec 13 09:47:29 2016

test: add once=True for BindKey in pytest recovery_button

So the button disappear after the test is started.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I41b5ad3d2969be5c0e01049e366051c1ad1bd7bb
Reviewed-on: https://chromium-review.googlesource.com/418146
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/2cb4fc746f946a71d9831ef9741df1fc8594a695/py/test/pytests/recovery_button.py
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/58967748ba74db2193aa914cf82f2220c657d8a9

commit 58967748ba74db2193aa914cf82f2220c657d8a9
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Dec 15 08:50:47 2016

test: add once=True for BindKey in pytest wifi_throughput

So the button disappear after retrying, and there wouldn't be duplicated
buttons for multiple retry.

BUG= chromium:670277 
TEST=make test

Change-Id: I5a5659414bc04f1d5ee9954cb5b3015a9aeeb4ed
Reviewed-on: https://chromium-review.googlesource.com/419945
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/58967748ba74db2193aa914cf82f2220c657d8a9/py/test/pytests/wifi_throughput.py
Project Member

Comment 21 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/aa681aa2822287fe778e6909fd43e405479a29ae

commit aa681aa2822287fe778e6909fd43e405479a29ae
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Dec 15 09:22:48 2016

test: fix can't finish pytest brightness on touchscreen only

The test call BindStandardKeys before initialize a template, causing the
buttons not appearing. Put initializing the template to before
BindStandardKeys to fix this.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I8f5aaec87d9b3c6e4ee5ad722a114f44181526ed
Reviewed-on: https://chromium-review.googlesource.com/420109
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/aa681aa2822287fe778e6909fd43e405479a29ae/py/test/pytests/brightness/brightness.py
Project Member

Comment 22 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/e95aec4f7f3225b01d22326c8eb13e6d8305637f

commit e95aec4f7f3225b01d22326c8eb13e6d8305637f
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Dec 15 10:04:22 2016

test: use ui_templates.OneSection for pytest summary

To make virtualkey buttons works, since summary can't be marked as
failed without keyboard.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I2daf634a165ae87ad9a8b60854c58fb32acacb49
Reviewed-on: https://chromium-review.googlesource.com/420189
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/e95aec4f7f3225b01d22326c8eb13e6d8305637f/py/test/pytests/summary/summary.py
Project Member

Comment 23 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/0f9a92bbb6f26372e71265c5e931b07f4b07bc95

commit 0f9a92bbb6f26372e71265c5e931b07f4b07bc95
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Dec 15 08:38:50 2016

test: add once=True for BindKey in pytest wifi_rf

So the button disappear after the test is started, and there won't be
duplicated buttons on TestFinish.

BUG= chromium:670277 
TEST=make test

Change-Id: I4036bde790dd52f97c318372d49568560dfce34d
Reviewed-on: https://chromium-review.googlesource.com/420584
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/0f9a92bbb6f26372e71265c5e931b07f4b07bc95/py/test/pytests/wifi_rf.py
Project Member

Comment 24 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/71b7dab3b4c5b1717b65c84748e2a5341d4eb61f

commit 71b7dab3b4c5b1717b65c84748e2a5341d4eb61f
Author: Peter Shih <pihsun@chromium.org>
Date: Fri Dec 16 07:05:19 2016

test: improve pytest led on touchscreen only

Make the challenge-based test's label directly clickable, so it's more
straightforward to answer the challenge. Also fixed a bug that the
FactoryTask doesn't clear event handlers between tasks, so led subtask
would be passed multiple times in a later subtest.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I1098b3c35023f4a7a3559a7d72770cbd9310cf6f
Reviewed-on: https://chromium-review.googlesource.com/421407
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/71b7dab3b4c5b1717b65c84748e2a5341d4eb61f/py/test/factory_task.py
[modify] https://crrev.com/71b7dab3b4c5b1717b65c84748e2a5341d4eb61f/py/test/pytests/led/led.py
Project Member

Comment 25 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/48b38ff477aefa8fa96592a60c74594087be94a3

commit 48b38ff477aefa8fa96592a60c74594087be94a3
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Dec 15 06:30:20 2016

test: minor fix on pytest spatial_sensor_calibration

Move BindKey to setUp instead of in runTest, so that there won't be more
buttons when retrying. Also fix a bug that the old board API dut.Read is
called.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I0a7a286dbf2ece24a7da15c9509cdf6fcb150c35
Reviewed-on: https://chromium-review.googlesource.com/420206
Commit-Ready: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/48b38ff477aefa8fa96592a60c74594087be94a3/py/test/pytests/spatial_sensor_calibration.py
Project Member

Comment 26 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/39af9648fc7da2fc12eba80c4bf80200c33c63a9

commit 39af9648fc7da2fc12eba80c4bf80200c33c63a9
Author: Peter Shih <pihsun@chromium.org>
Date: Fri Dec 16 03:11:15 2016

test: fix can't finish pytest touchscreen on touchscreen only

Since the test did touchscreen_device.grab() on setUp(), we can't
interact with on screen buttons. Change it to only call .grab() after
the first space pressed. Also add a countdown timer similar to touchpad,
so that the test can be finished (and failed) with touchscreen only even
if there's some area of touchscreen broken.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I3e278f3752a6569dc4adbb0c8d00022ebf2f6a2c
Reviewed-on: https://chromium-review.googlesource.com/421068
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/39af9648fc7da2fc12eba80c4bf80200c33c63a9/py/test/pytests/touchscreen_static/touchscreen.css
[modify] https://crrev.com/39af9648fc7da2fc12eba80c4bf80200c33c63a9/py/test/pytests/touchscreen_static/touchscreen.js
[modify] https://crrev.com/39af9648fc7da2fc12eba80c4bf80200c33c63a9/py/test/pytests/touchscreen.py
[modify] https://crrev.com/39af9648fc7da2fc12eba80c4bf80200c33c63a9/py/test/countdown_timer.py
Project Member

Comment 27 by bugdroid1@chromium.org, Feb 6 2017

Labels: merge-merged-factory-reef-8811.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/d3962522b92630b44ba655f76dc5f1efea8e3980

commit d3962522b92630b44ba655f76dc5f1efea8e3980
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 06 07:00:26 2017

test: minor fix on pytest spatial_sensor_calibration

Move BindKey to setUp instead of in runTest, so that there won't be more
buttons when retrying. Also fix a bug that the old board API dut.Read is
called.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I0a7a286dbf2ece24a7da15c9509cdf6fcb150c35
Reviewed-on: https://chromium-review.googlesource.com/420206
Commit-Ready: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
(cherry picked from commit 48b38ff477aefa8fa96592a60c74594087be94a3)
Reviewed-on: https://chromium-review.googlesource.com/438208
Commit-Queue: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/d3962522b92630b44ba655f76dc5f1efea8e3980/py/test/pytests/spatial_sensor_calibration.py

Comment 28 by youcheng@chromium.org, Feb 13 2017

Cc: youcheng@chromium.org
Project Member

Comment 29 by bugdroid1@chromium.org, Feb 13 2017

Labels: merge-merged-factory-gru-9017.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/239c9e136fbdc2ca7991b692d70171aee95c1db7

commit 239c9e136fbdc2ca7991b692d70171aee95c1db7
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:21:20 2017

goofy: add toggle engineering mode to menu item

So we can enter engineering mode by touch screen only.

BUG= chromium:670277 
TEST=make test

Change-Id: I6d077c34485725ed604ce0b363951c3f1dbe0965
Reviewed-on: https://chromium-review.googlesource.com/415654
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441463
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/239c9e136fbdc2ca7991b692d70171aee95c1db7/py/goofy/js/goofy.js
Project Member

Comment 30 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/3565bcf64339d29afcc926c745f6ef535574634c

commit 3565bcf64339d29afcc926c745f6ef535574634c
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:23:00 2017

test: remove unused template.BindStandardKeys()

Reverts CL:32123, since this function is never used by anyone, and we'll
probably need the place for virtual keys on screen in touch screen UI.

BUG= chromium:670277 
TEST=make test

Change-Id: I19cd587ec0a3d7b1e5dc9349e303f636f2cef139
Reviewed-on: https://chromium-review.googlesource.com/416469
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441685
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/3565bcf64339d29afcc926c745f6ef535574634c/py/goofy/static/ui_templates/template_one_scrollable_section.html
[modify] https://crrev.com/3565bcf64339d29afcc926c745f6ef535574634c/py/goofy/static/ui_templates/template_two_sections.html
[modify] https://crrev.com/3565bcf64339d29afcc926c745f6ef535574634c/py/goofy/static/ui_templates/template_one_section.html
[modify] https://crrev.com/3565bcf64339d29afcc926c745f6ef535574634c/py/test/ui_templates.py
Project Member

Comment 31 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/ebe423a6770d637e6909882469a2df6daf6389b8

commit ebe423a6770d637e6909882469a2df6daf6389b8
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:22:17 2017

goofy: add onscreen link to cancel pending shutdown

so we can cancel pending shutdown by touchscreen only.

BUG= chromium:670277 
TEST=make test

Change-Id: Ie1fd23afa714c4ea54c461c3b0d91a031e8fa47d
Reviewed-on: https://chromium-review.googlesource.com/416029
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441684
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/ebe423a6770d637e6909882469a2df6daf6389b8/py/goofy/js/goofy.js
Project Member

Comment 32 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/7c4ecdf864d33f01010740d414a270382359ee7b

commit 7c4ecdf864d33f01010740d414a270382359ee7b
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:23:31 2017

test: enforce tests to use BindKey instead of custom JS

So we can have an unified interface for registering key binding, and can
hook BindKey to add on-screen touch support for key binding later.

BUG= chromium:670277 
TEST=make test

Change-Id: I8a66de60498502e8d1933064499f7428310b49dc
Reviewed-on: https://chromium-review.googlesource.com/416030
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@google.com>
Reviewed-on: https://chromium-review.googlesource.com/441686
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/audio_loop/audio_loop.js
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/audio_basic.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/ethernet.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/audio_quality_static/audio_quality.js
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/audio_loop/audio_loop.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/camera_fixture_static/camera_fixture.js
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/recovery_button.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/start/start.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/test_ui.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/buzzer.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/camera_fixture.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/check_image_version.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/touchscreen_calibration/touchscreen_calibration.html
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/accelerometers_lid_angle.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/touchscreen_calibration/touchscreen_calibration.js
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/touchscreen_calibration/touchscreen_calibration.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/light_sensor.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/vpd_from_http.py
[modify] https://crrev.com/7c4ecdf864d33f01010740d414a270382359ee7b/py/test/pytests/audio_quality.py
Project Member

Comment 33 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/cdd4b0f4c92a0d0246995e0c75bc1b55c92a2610

commit cdd4b0f4c92a0d0246995e0c75bc1b55c92a2610
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:24:06 2017

test: fix some test doesn't work well with touch screen only

Some tests require keyboard to exit full-screen mode, change them to
also accept a click on screen to exit full-screen mode.

BUG= chromium:670277 
TEST=make test

Change-Id: Ia038e235eb9a09a9cce4bcf0a501cacf7cc8c3dd
Reviewed-on: https://chromium-review.googlesource.com/417423
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441687
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/cdd4b0f4c92a0d0246995e0c75bc1b55c92a2610/py/test/pytests/display_point.py
[modify] https://crrev.com/cdd4b0f4c92a0d0246995e0c75bc1b55c92a2610/py/test/pytests/display_idle_static/display_idle.js
[modify] https://crrev.com/cdd4b0f4c92a0d0246995e0c75bc1b55c92a2610/py/test/pytests/display_point_static/display_point.js
[modify] https://crrev.com/cdd4b0f4c92a0d0246995e0c75bc1b55c92a2610/py/test/pytests/display.py
[modify] https://crrev.com/cdd4b0f4c92a0d0246995e0c75bc1b55c92a2610/py/test/pytests/display_idle.py
[modify] https://crrev.com/cdd4b0f4c92a0d0246995e0c75bc1b55c92a2610/py/test/pytests/display_static/display.js
Project Member

Comment 34 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/2e06b3a5b8c3358ac3301ecf3ff6c3ec044187ac

commit 2e06b3a5b8c3358ac3301ecf3ff6c3ec044187ac
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:24:42 2017

test: add virtual key buttons on screen when BindKey

Add buttons on screen for keyboard operations, to better support using
touch screen only for factory testing.

BUG= chromium:670277 
TEST=make test

Change-Id: If08298ce5f2409e857d245049ae0101905c60173
Reviewed-on: https://chromium-review.googlesource.com/417720
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441688
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/2e06b3a5b8c3358ac3301ecf3ff6c3ec044187ac/py/goofy/static/ui_templates/template.css
[modify] https://crrev.com/2e06b3a5b8c3358ac3301ecf3ff6c3ec044187ac/py/test/test_ui.py
[modify] https://crrev.com/2e06b3a5b8c3358ac3301ecf3ff6c3ec044187ac/py/goofy/static/ui_templates/template_one_scrollable_section.html
[modify] https://crrev.com/2e06b3a5b8c3358ac3301ecf3ff6c3ec044187ac/py/goofy/static/ui_templates/template_one_section.html
[modify] https://crrev.com/2e06b3a5b8c3358ac3301ecf3ff6c3ec044187ac/py/goofy/static/ui_templates/template_two_sections.html
[modify] https://crrev.com/2e06b3a5b8c3358ac3301ecf3ff6c3ec044187ac/py/goofy/js/goofy.js
Project Member

Comment 35 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/330416975bc2ac81c40db23a5e9e9f798fe58628

commit 330416975bc2ac81c40db23a5e9e9f798fe58628
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:25:14 2017

test: rework pytest display_point challenge response

The old way to respond to challenge in display_point pytest is using a
text input, which would need a virtual keyboard to be popped out if we
want to use touchscreen only. But the virtual keyboard would interfere
with the following fullscreen test.

Since we probably never want to have challenge of more than 10 points
(default is 3), a single number keypress is enough for challenge
response. This makes using touchscreen only easier.

This also simplify the process of answering. Assuming that the answers
are 2 and 3.
Keystrokes to pass old test:
  [Space] [Space] 2 [Enter] [Space] 3 [Enter]
Keystrokes to pass new test:
  [Space] 2 3

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: Ia3bfbfa2812572a6c638940af0ba747e14307788
Reviewed-on: https://chromium-review.googlesource.com/417683
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441689
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/330416975bc2ac81c40db23a5e9e9f798fe58628/py/test/pytests/display_point.py
[modify] https://crrev.com/330416975bc2ac81c40db23a5e9e9f798fe58628/py/test/pytests/display_point_static/display_point.js
Project Member

Comment 36 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/ba380296b386cbce9a399dec78bcb3c5b928c9b4

commit ba380296b386cbce9a399dec78bcb3c5b928c9b4
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:26:25 2017

test: improve UI of pytest camera when using touchscreen only.

In led_manual, the code bind 0~9 when only using 0 and 1. Also,
capture_manual bind enter and esc each frame, causing the buttons to be
repeated added. Fix both.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I5b2ae09403cdbebfd314ae7acaf7e02e5cc003da
Reviewed-on: https://chromium-review.googlesource.com/418520
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441691
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/ba380296b386cbce9a399dec78bcb3c5b928c9b4/py/test/factory_task.py
[modify] https://crrev.com/ba380296b386cbce9a399dec78bcb3c5b928c9b4/py/test/pytests/camera.py
Project Member

Comment 37 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/68a3596c1c25df979b04a35365f7f8b45b19a2b3

commit 68a3596c1c25df979b04a35365f7f8b45b19a2b3
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:25:50 2017

test: fix can't finish pytest audio_quality on touchscreen only

The test is not using standard templates, so we have to add a
virtualkey-button-container to HTML manually.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: Ie30d86a8911f3a9a992afe6ce377c56c96191ced
Reviewed-on: https://chromium-review.googlesource.com/418428
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441690
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/68a3596c1c25df979b04a35365f7f8b45b19a2b3/py/test/pytests/audio_quality_static/audio_quality.html
Project Member

Comment 38 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/8301567d45a6b060c2db461ffcaa77b9579ac77c

commit 8301567d45a6b060c2db461ffcaa77b9579ac77c
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:26:54 2017

pytest: Fix pytest audio doesn't work well on touchscreen only

There are some BindKey that's called multiple times across multiple
runs, causing the buttons to appear twice. Remove all key bindings on
FactoryTask._Finish.

Also don't bind ENTER in InteractiveFactoryTask.BindPassFailKeys if
pass_key=False.

Also fix a bug that javascript keycode is always uppercase, thus binding
lowercase characters doesn't work.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I12d7fae39ca361ec8cd4eacab970defb79277f11
Reviewed-on: https://chromium-review.googlesource.com/418536
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441692
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/8301567d45a6b060c2db461ffcaa77b9579ac77c/py/test/pytests/audio.py
[modify] https://crrev.com/8301567d45a6b060c2db461ffcaa77b9579ac77c/py/test/factory_task.py
[modify] https://crrev.com/8301567d45a6b060c2db461ffcaa77b9579ac77c/py/test/test_ui.py
[modify] https://crrev.com/8301567d45a6b060c2db461ffcaa77b9579ac77c/py/goofy/js/goofy.js
Project Member

Comment 39 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/490d964845dab320bb709b0ed8f71e493f6a09eb

commit 490d964845dab320bb709b0ed8f71e493f6a09eb
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:27:31 2017

test: minor change in instruction of some pytests.

from "" to "", to match label displayed on virtualkey button.

BUG= chromium:670277 
TEST=None

Change-Id: Ia4321f40ad48ca82598ef133a6b35837f8873da7
Reviewed-on: https://chromium-review.googlesource.com/418638
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441693
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/490d964845dab320bb709b0ed8f71e493f6a09eb/py/test/pytests/wifi_rf.py
[modify] https://crrev.com/490d964845dab320bb709b0ed8f71e493f6a09eb/py/test/pytests/display_idle_static/display_idle.js
[modify] https://crrev.com/490d964845dab320bb709b0ed8f71e493f6a09eb/py/test/pytests/backlight_static/backlight.js
[modify] https://crrev.com/490d964845dab320bb709b0ed8f71e493f6a09eb/py/test/pytests/display_point_static/display_point.js
[modify] https://crrev.com/490d964845dab320bb709b0ed8f71e493f6a09eb/py/test/pytests/touchscreen_static/touchscreen.js
[modify] https://crrev.com/490d964845dab320bb709b0ed8f71e493f6a09eb/py/test/pytests/display_static/display.js
Project Member

Comment 40 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/f069b146e83eac4ccce4e1ba49709b75bd53c4be

commit f069b146e83eac4ccce4e1ba49709b75bd53c4be
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:28:03 2017

test: add once=True for BindKey in pytest recovery_button

So the button disappear after the test is started.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I41b5ad3d2969be5c0e01049e366051c1ad1bd7bb
Reviewed-on: https://chromium-review.googlesource.com/418146
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441694
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/f069b146e83eac4ccce4e1ba49709b75bd53c4be/py/test/pytests/recovery_button.py
Project Member

Comment 41 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/2888ae4eefd6474a3d11389b5ce62a418f10fb9f

commit 2888ae4eefd6474a3d11389b5ce62a418f10fb9f
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:28:36 2017

test: fix can't finish pytest brightness on touchscreen only

The test call BindStandardKeys before initialize a template, causing the
buttons not appearing. Put initializing the template to before
BindStandardKeys to fix this.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I8f5aaec87d9b3c6e4ee5ad722a114f44181526ed
Reviewed-on: https://chromium-review.googlesource.com/420109
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441695
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/2888ae4eefd6474a3d11389b5ce62a418f10fb9f/py/test/pytests/brightness/brightness.py
Project Member

Comment 42 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/98f36589c82cc7a5c6949ef110c0e678a7ca65ac

commit 98f36589c82cc7a5c6949ef110c0e678a7ca65ac
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:29:05 2017

test: add once=True for BindKey in pytest wifi_throughput

So the button disappear after retrying, and there wouldn't be duplicated
buttons for multiple retry.

BUG= chromium:670277 
TEST=make test

Change-Id: I5a5659414bc04f1d5ee9954cb5b3015a9aeeb4ed
Reviewed-on: https://chromium-review.googlesource.com/419945
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@google.com>
Reviewed-on: https://chromium-review.googlesource.com/441696
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/98f36589c82cc7a5c6949ef110c0e678a7ca65ac/py/test/pytests/wifi_throughput.py
Project Member

Comment 43 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/09192dd51033b41bedb975acdca320dc0de27d9f

commit 09192dd51033b41bedb975acdca320dc0de27d9f
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:29:36 2017

test: use ui_templates.OneSection for pytest summary

To make virtualkey buttons works, since summary can't be marked as
failed without keyboard.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I2daf634a165ae87ad9a8b60854c58fb32acacb49
Reviewed-on: https://chromium-review.googlesource.com/420189
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441697
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/09192dd51033b41bedb975acdca320dc0de27d9f/py/test/pytests/summary/summary.py
Project Member

Comment 44 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/ca11de76cb834a7cddcf12ad84c4452001c315a5

commit ca11de76cb834a7cddcf12ad84c4452001c315a5
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:30:22 2017

test: add once=True for BindKey in pytest wifi_rf

So the button disappear after the test is started, and there won't be
duplicated buttons on TestFinish.

BUG= chromium:670277 
TEST=make test

Change-Id: I4036bde790dd52f97c318372d49568560dfce34d
Reviewed-on: https://chromium-review.googlesource.com/420584
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441698
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/ca11de76cb834a7cddcf12ad84c4452001c315a5/py/test/pytests/wifi_rf.py
Project Member

Comment 45 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/138e7e17088979859bb4a94b609021feb51efb4c

commit 138e7e17088979859bb4a94b609021feb51efb4c
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:30:52 2017

test: improve pytest led on touchscreen only

Make the challenge-based test's label directly clickable, so it's more
straightforward to answer the challenge. Also fixed a bug that the
FactoryTask doesn't clear event handlers between tasks, so led subtask
would be passed multiple times in a later subtest.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I1098b3c35023f4a7a3559a7d72770cbd9310cf6f
Reviewed-on: https://chromium-review.googlesource.com/421407
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@google.com>
Reviewed-on: https://chromium-review.googlesource.com/441699
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/138e7e17088979859bb4a94b609021feb51efb4c/py/test/factory_task.py
[modify] https://crrev.com/138e7e17088979859bb4a94b609021feb51efb4c/py/test/pytests/led/led.py
Project Member

Comment 46 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/da445beb1e8f94cfe9107d1b485ea506b3c69f64

commit da445beb1e8f94cfe9107d1b485ea506b3c69f64
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:31:21 2017

test: minor fix on pytest spatial_sensor_calibration

Move BindKey to setUp instead of in runTest, so that there won't be more
buttons when retrying. Also fix a bug that the old board API dut.Read is
called.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I0a7a286dbf2ece24a7da15c9509cdf6fcb150c35
Reviewed-on: https://chromium-review.googlesource.com/420206
Commit-Ready: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/441700
Reviewed-by: Youcheng Syu <youcheng@google.com>
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/da445beb1e8f94cfe9107d1b485ea506b3c69f64/py/test/pytests/spatial_sensor_calibration.py
Project Member

Comment 47 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/caead2ec4b2d6eef9b295446bdf085f0df8e970c

commit caead2ec4b2d6eef9b295446bdf085f0df8e970c
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Feb 13 04:31:51 2017

test: fix can't finish pytest touchscreen on touchscreen only

Since the test did touchscreen_device.grab() on setUp(), we can't
interact with on screen buttons. Change it to only call .grab() after
the first space pressed. Also add a countdown timer similar to touchpad,
so that the test can be finished (and failed) with touchscreen only even
if there's some area of touchscreen broken.

BUG= chromium:670277 
TEST=make test
TEST=manually tested, put the test on DUT, and check that the test can
     be easily completed with touchscreen only.

Change-Id: I3e278f3752a6569dc4adbb0c8d00022ebf2f6a2c
Reviewed-on: https://chromium-review.googlesource.com/421068
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@google.com>
Reviewed-on: https://chromium-review.googlesource.com/441701
Commit-Queue: Youcheng Syu <youcheng@google.com>
Tested-by: Youcheng Syu <youcheng@google.com>

[modify] https://crrev.com/caead2ec4b2d6eef9b295446bdf085f0df8e970c/py/test/pytests/touchscreen_static/touchscreen.css
[modify] https://crrev.com/caead2ec4b2d6eef9b295446bdf085f0df8e970c/py/test/pytests/touchscreen_static/touchscreen.js
[modify] https://crrev.com/caead2ec4b2d6eef9b295446bdf085f0df8e970c/py/test/pytests/touchscreen.py
[modify] https://crrev.com/caead2ec4b2d6eef9b295446bdf085f0df8e970c/py/test/countdown_timer.py

Comment 48 by pihsun@chromium.org, May 16 2017

Status: Fixed (was: Assigned)
Project Member

Comment 49 by bugdroid1@chromium.org, Jun 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/527382a2bec9d50b52a09cd8348b851c7bc16c86

commit 527382a2bec9d50b52a09cd8348b851c7bc16c86
Author: Peter Shih <pihsun@chromium.org>
Date: Thu Jun 29 10:11:35 2017

pytest: Fix light_sensor doesn't work with touch-only UI.

The light_sensor pytest use custom HTML file instead of template, so the
touch UI doesn't work. Manually apply the template HTML to the custom
HTML file to solve this.

BUG= chromium:670277 
TEST=make test
TEST=manually on DUT.

Change-Id: Iaf4b73e278124487a5dfb6aeab4c08f35308f83a
Reviewed-on: https://chromium-review.googlesource.com/554441
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Yilun Lin <yllin@chromium.org>

[modify] https://crrev.com/527382a2bec9d50b52a09cd8348b851c7bc16c86/py/test/pytests/light_sensor_static/light_sensor.html

Comment 50 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 51 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment