Issue metadata
Sign in to add a comment
|
Position:Sticky + Box-Shadow Breaks Positioning
Reported by
azmer...@gmail.com,
Dec 1 2016
|
||||||||||||||||||||||
Issue descriptionSteps to reproduce the problem: 1. Open: http://codepen.io/Kelderic/full/XNVdZx/ 2. Look at sticky nav. What is the expected behavior? Should be fully left, touching edge of page. What went wrong? It's not fully left. It's been moved to the right, and down. Did this work before? No Does this work in other browsers? Yes Chrome version: 56.0.2924.10 Channel: dev OS Version: 5.1 Flash Version: Removing box-shadow causes the bug to disappear. Also this tracker doesn't work in Firefox. Filled out the report and got a blank white page. Trying in Chrome now.
,
Dec 12 2016
I can now reproduce this issue on Windows 10, with Chrome 56.0.2924.18 dev (64-bit). Also still broken in Chrome 56 and 57 on Android. Specifically 56.0.2924.18, and 57.0.2946.0.
,
Dec 13 2016
This is now happening in Chrome Beta, v 56.0.2924.23. It's a little surprising to me that no one has responded to this. It's a pretty visible bug. Any websites that are using sticky positioning look mildly broken on Chrome 56 and up.
,
Dec 14 2016
,
Dec 15 2016
@azmercer@gmail.com, unable to reproduce your issue as "http://codepen.io/Kelderic/full/XNVdZx/" is now redirecting to "http://codepen.io/anddo/full/XNVdZx/". Can you provide correct link to verify the issue.
,
Dec 15 2016
When fully logged out of Codepen, that link is working for me. However, here is a mirror: https://jsfiddle.net/LjmaLcky/ I've noticed it only appears when the wrapper window is scrollable. My guess is that when it's not scrollable, then the sticky is rendered as static.
,
Dec 15 2016
Also I'm adding the test case as a self-contained HTML file attachment in case that second link doesn't work either.
,
Dec 16 2016
@dknandiraju@chromium.org, does the new link/attachment work for you to verify the issue?
,
Dec 20 2016
1) Bisect Range: https://chromium.googlesource.com/chromium/src/+log/56.0.2909.0..56.0.2910.0?pretty=fuller&n=10000 2) Bisect script pointed to: https://chromium.googlesource.com/chromium/src/+/77a8c51a440e0741315ff5e9e77441b86cbbc56d @flackr, can you please look into this,thanks
,
Dec 20 2016
,
Dec 20 2016
,
Dec 21 2016
Same problem on Windows 7 with: Chrome 56 beta (64-bits) and Canary 57.0.2957.0 (64-bits)
,
Dec 29 2016
This is still broken on 57.0.2950.4 on Windows 10.
,
Jan 6 2017
Just a bump because we are less than 2 weeks away from this bug being in the public release channel.
,
Jan 16 2017
3 days until this is broken on Stable.
,
Jan 16 2017
Apologies for the absence, I was on vacation over the holidays. The issue is only with composited sticky - when sticky position is updated on the main thread (i.e. non retina non-opaque sticky elements) it is updated correctly. This suggests that the main thread offset passed to the compositor needs to be adjusted by the additional compositing offset caused by the box shadow.
,
Jan 17 2017
Issue 670953 has been merged into this issue.
,
Jan 17 2017
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/653e80aeeaac895c6f9bfb6181655f15f29cb0be commit 653e80aeeaac895c6f9bfb6181655f15f29cb0be Author: flackr <flackr@chromium.org> Date: Wed Jan 18 22:57:23 2017 Add offset of content in composited layer to sticky position offset. The actual sticky layoutobject may have an offset within its composited layer which needs to be included in the compositing update of sticky positioning. BUG= 670274 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2636233002 Cr-Commit-Position: refs/heads/master@{#444527} [modify] https://crrev.com/653e80aeeaac895c6f9bfb6181655f15f29cb0be/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/653e80aeeaac895c6f9bfb6181655f15f29cb0be/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
,
Jan 19 2017
Awesome! So will this be uplifted up through v56? Or just apply to Canary?
,
Jan 19 2017
Unfortunately, as innocuous as this patch is I think it's too late to merge back, so it will just apply to Chrome 57+.
,
Jan 19 2017
Well that kinda sucks, but it is what it is. I did just get an update on Canary, on my phone and can confirm that the bug is fixed.
,
Jan 19 2017
Issue 678914 has been merged into this issue.
,
Feb 7 2017
Issue 688022 has been merged into this issue.
,
Feb 23 2017
Issue 690381 has been merged into this issue.
,
Feb 23 2017
Issue 695085 has been merged into this issue.
,
Mar 2 2017
Issue 697186 has been merged into this issue.
,
Mar 15 2017
Issue 674356 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by azmer...@gmail.com
, Dec 1 2016106 KB
106 KB View Download