Setting pepper volume from MediaSession is only sent to the main frame |
||
Issue descriptionI just realized that I made a mistake where the IPC message for setting pepper volume is only sent to the main frame from WebContents. Marking as P3 since we currently prefer one-shot focus for pepper. But this should be fixed if we decide to duck/mute pepper some day.
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b6f4f00951c96ba468bd8ad554fda1065bacfa6 commit 7b6f4f00951c96ba468bd8ad554fda1065bacfa6 Author: zqzhang <zqzhang@chromium.org> Date: Wed Dec 07 22:10:22 2016 Route Pepper MediaSession messages to frames This CL fixes an issue that SetPepperVolume (coming from MediaSession) is only sent to the top-level frame. Instead, the message should be handled by the frames which created the Pepper instance. The issue can cause a crash if there is a Pepper instance playing sound in a cross-origin iframe while site-isolation is enabled. Now we use pair <RenderFrameHost, pp_instance> as player id so that SetPepperVolume can be sent to the correct frame. BUG= 670273 Review-Url: https://codereview.chromium.org/2551093002 Cr-Commit-Position: refs/heads/master@{#437079} [modify] https://crrev.com/7b6f4f00951c96ba468bd8ad554fda1065bacfa6/content/browser/media/session/pepper_playback_observer.cc [modify] https://crrev.com/7b6f4f00951c96ba468bd8ad554fda1065bacfa6/content/browser/media/session/pepper_playback_observer.h [modify] https://crrev.com/7b6f4f00951c96ba468bd8ad554fda1065bacfa6/content/browser/media/session/pepper_player_delegate.cc [modify] https://crrev.com/7b6f4f00951c96ba468bd8ad554fda1065bacfa6/content/browser/media/session/pepper_player_delegate.h [modify] https://crrev.com/7b6f4f00951c96ba468bd8ad554fda1065bacfa6/content/browser/web_contents/web_contents_impl.cc
,
Dec 8 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by zqzh...@chromium.org
, Dec 2 2016