imageCapture: zoom is 0 the first time |
||||||
Issue descriptionChrome Version : 56.0.2924.9 OS Version: 9000.10.0 What steps will reproduce the problem? 1. calling the first time getPhotoCapabilities() return a zoom set to 0 2. refreshing page and calling a second time getPhotoCapabilities return a proper range for zoom (non 0 for min and max)
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba3e7171459cfa4bc9c0c26329a88ff3a4c21bd6 commit ba3e7171459cfa4bc9c0c26329a88ff3a4c21bd6 Author: mcasas <mcasas@chromium.org> Date: Tue Dec 06 19:27:12 2016 ImageCapture: queue requests if device is not started (Linux,CrOs) This CL is the continuation of https://crrev.com/2193213003 for CrOs. Said CL added a queue of image-capture related requests in VideoCaptureManager and in VideoCaptureDeviceAndroid, this CL adds such a queue in VideoCaptureDeviceLinux, otherwise (see bug) there is a race between the photo related requests and the device startup, which can take a while and happens asynchronously. BUG= 670262 , 627537 Review-Url: https://codereview.chromium.org/2557623002 Cr-Commit-Position: refs/heads/master@{#436684} [modify] https://crrev.com/ba3e7171459cfa4bc9c0c26329a88ff3a4c21bd6/media/capture/video/linux/video_capture_device_linux.cc [modify] https://crrev.com/ba3e7171459cfa4bc9c0c26329a88ff3a4c21bd6/media/capture/video/linux/video_capture_device_linux.h
,
Dec 6 2016
Should be fixed now. fbeaufort@ would you mind verifying it?
,
Dec 6 2016
,
Dec 13 2016
It is not fixed in my case in Chrome OS 57.0.2948.0 ;( If I go to https://beaufortfrancois.github.io/sandbox/image-capture/playground.html, the zoom input is disabled. Refreshing page makes it work after though. I'm not sure what is happening there.
,
Dec 16 2016
#5: Managed to repro somehow, and it's quite weird since
the other capabilities (brightness, sharpness etc) get
picked up correctly. The not-read also affects the colour
temperature (white balance temperature).
I believe this has to do with the uvc driver getting a bit
stuck in the first VIDIOC_{QUERY,G_}CTRL commands -- this
happened here: [1], we'll probably try something similar
here.
[1] https://cs.chromium.org/chromium/src/media/capture/video/linux/v4l2_capture_delegate.cc?q=ResetUserAndCameraControlsToDefault&sq=package:chromium&dr=CSs&l=172
,
Dec 16 2016
Is that a known issue in UVC driver? Where could we ask for help there?
,
Dec 16 2016
#7: https://codereview.chromium.org/2582723002/# is the CL
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/047c7091b7159c5ad0037d0e35d74e1e4739e080 commit 047c7091b7159c5ad0037d0e35d74e1e4739e080 Author: mcasas <mcasas@chromium.org> Date: Fri Dec 16 22:48:44 2016 ImageCapture v4l2: retry reading capabilities The bug illustrates a case in which an ioctl() for reading the photo capabilities right after opening the device/starting streaming fails, but work after retrying a few times. (In my repros, the first two control readings fail, successively working). This CL reuses the code in ResetUserAndCameraControlsToDefault() to retry an ioclt a few times for RetrieveUserControlRange(). BUG= 670262 Review-Url: https://codereview.chromium.org/2582723002 Cr-Commit-Position: refs/heads/master@{#439223} [modify] https://crrev.com/047c7091b7159c5ad0037d0e35d74e1e4739e080/media/capture/video/linux/v4l2_capture_delegate.cc
,
Dec 16 2016
fbeaufort@ let's give it another stab either you or I when 439223 hits Canary.
,
Dec 19 2016
Just tried with a CrOS 57.0.2955.0 and it retrieved the values right the first time (including colorTemperature and zoom), so, I'd say it's verified. fbeaufort@, please reopen otherwise.
,
Dec 23 2016
Verified in Chrome Canary 57.0.2958.0. Thank you! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fbeaufort@chromium.org
, Dec 1 2016