Issue metadata
Sign in to add a comment
|
Regression : Permission bubble is not seen completely (i.e the top part of bubble is not visible) in fullscreen mode.
Reported by
yfulgaon...@etouch.net,
Dec 1 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 57.0.2938.0 3495268d34006ced6ab8d55d3d55edd0f3469613-refs/heads/master@{#435514} 64 bit OS : Mac(10.11.6, 10.12.1, 10.12) Test URL : https://permission.site/ What steps will reproduce the problem? 1. Launch chrome, navigate to above URL and click on browser’s ’Fullscreen’ icon seen in top left corner (browser enters into fullscreen mode). 2. Now click on “Fullscreen” button (seen on page) and then click on “Microphone” button and observe the bubble. Actual : Permission bubble is not seen completely i.e the top part of bubble is not visible in fullscreen mode. Expected : Permission bubble should be seen completely in fullscreen mode. This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update other info. Good build : 56.0.2916.0 Bad build : 56.0.2917.0 Note : This is Mac specific issue and the same is not reproducible on Windows & Linux OS.
,
Dec 1 2016
I tested this on Canary and it looks like it's fixed. Can you confirm that it's not reproducible on M57?
,
Dec 1 2016
Actually, I'm testing this right now on M56 and I can't reproduce this either
,
Dec 1 2016
yfulgaonkar@ Please verify in latest canary.
,
Dec 2 2016
With response to comment #3 & 4 Precondition : Please make sure that "Always show toolbar in full screen" option is ticked under "View" menu. Retested on Mac 56.0.2924.13 dev and 57.0.2938.0 Canary builds and issue is still reproducible. Kindly review an attached screen of both Dev and Canary builds. Thank you!
,
Dec 2 2016
Ah, I see. I'm able to reproduce this. Investigating the issue now
,
Dec 2 2016
Thanks for the update. FYI: M56 Beta promotion is scheduled on Dec 6 & RC cut on Monday, Dec 5 @ 4.00 PM PST.Please ensure to verify the fix and merge your change ASAP so that we could take it for next Release.
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72a9bc5acf1c8a203d108a58b69a8f2f8ae17aaf commit 72a9bc5acf1c8a203d108a58b69a8f2f8ae17aaf Author: spqchan <spqchan@chromium.org> Date: Fri Dec 02 22:44:43 2016 [Mac] Fixed permission bubble position in fullscreen BUG= 670254 Review-Url: https://codereview.chromium.org/2549863002 Cr-Commit-Position: refs/heads/master@{#436062} [modify] https://crrev.com/72a9bc5acf1c8a203d108a58b69a8f2f8ae17aaf/chrome/browser/ui/cocoa/browser_window_controller.mm
,
Dec 2 2016
,
Dec 2 2016
Please don't merge to 56 before confirming this change in Canary.
,
Dec 3 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 5 2016
We will verify the fix in today's canary.
,
Dec 6 2016
Tested the issue on Latest Canary# 57.0.2943.0 on Mac OS X 10.11.6 and 10.12 1 and observed that the issue is no more reproducible. Able to see the complete bubble in Full Screen. Hence adding TE-Verified Labels accordingly. Attaching a screen cast for reference. Thank You.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f0a2fe6fd26d3112db7589dee1d3e8467839a9b commit 8f0a2fe6fd26d3112db7589dee1d3e8467839a9b Author: spqchan <spqchan@chromium.org> Date: Tue Dec 06 19:25:42 2016 [Mac] Fixed permission bubble position in fullscreen BUG= 670254 Review-Url: https://codereview.chromium.org/2549863002 Cr-Commit-Position: refs/heads/master@{#436062} (cherry picked from commit 72a9bc5acf1c8a203d108a58b69a8f2f8ae17aaf) Review URL: https://codereview.chromium.org/2557533003 . Cr-Commit-Position: refs/branch-heads/2924@{#360} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/8f0a2fe6fd26d3112db7589dee1d3e8467839a9b/chrome/browser/ui/cocoa/browser_window_controller.mm
,
Dec 6 2016
If there is no pending work please tag as fixed, we will verify in next M56 RC.
,
Dec 6 2016
,
Dec 8 2016
Tested the issue on Latest Dev# 56.0.2924.21 on Mac OS X 10.11.6 and 10.12.1 and observed that the issue is no more reproducible. Able to see the complete bubble in Full Screen. Hence adding TE-Verified Labels accordingly. Attaching a screen shot for reference. Thank You. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Dec 1 2016Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)