New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670238 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Continue' and 'Cancel' buttons of 'Confirmation dialog box' are seen chopped after changing browser font size.

Reported by rk...@etouch.net, Dec 1 2016

Issue description

Chrome Version: 57.0.2938.0 Revision 3495268d34006ced6ab8d55d3d55edd0f3469613-refs/heads/master@{#435514}
OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS)

Pre-condition: Change browser Font size to 'Very large' from chrome://md-settings

What steps will reproduce the problem?
(1) Launch chrome and click on avatar icon , sign in with valid credentials.
(2) Click on 'Undo' button of 'You're now signed in to Chrome' overlay.
(3) Again sign in with different credentials and observe bottom side of 'Confirmation dialog box'

Actual: Continue and Cancel buttons of 'Confirmation dialog box' are seen chopped.

Expected: Continue and Cancel buttons of 'Confirmation dialog box' should not seen chopped.

This is a regression issue broken in 'M57' and below is the manual regression range:
Good Build: 56.0.2924.0
Bad Build: 57.0.2926.0

ChageLog info:
https://chromium.googlesource.com/chromium/src/+log/56.0.2924.0..57.0.2926.0?pretty=fuller&n=10000

Suspecting: 433177 

Note: Unable to narrow down the range using tool bisect as can not sign into chromium builds.


 
Actual_Overlay.mp4
848 KB View Download
Expected_Overlay.mp4
651 KB View Download
Components: UI>Browser>WebUI
It was re-implemented using Web UI, which makes the font size affect it.

It is a little weird that it is still a standalone confirmation dialog instead of a simple HTML based dialog within the settings page.

Comment 2 by msarda@chromium.org, Dec 15 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6333edb8c4a6fe199bba36b0f453c81c06e6e3e9

commit 6333edb8c4a6fe199bba36b0f453c81c06e6e3e9
Author: msarda <msarda@chromium.org>
Date: Thu Dec 15 17:05:08 2016

Autoresize the sign-in email confirmation dialog.

This CL uses an auto-resizeble WebUI constrained dialog to ensure that
it is loaded with the right height.

Screenshots:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbTkVxc0twaDJhWjQ/view?usp=sharing
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbZmVFVXY1TnZmalU/view?usp=sharing

BUG= 670238 

Review-Url: https://codereview.chromium.org/2580663003
Cr-Commit-Position: refs/heads/master@{#438853}

[modify] https://crrev.com/6333edb8c4a6fe199bba36b0f453c81c06e6e3e9/chrome/browser/ui/webui/signin/signin_email_confirmation_dialog.cc

Comment 4 by msarda@chromium.org, Dec 15 2016

Status: Fixed (was: Started)

Sign in to add a comment