New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670237 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 702097

Blocking:
issue 612701
issue 674404



Sign in to add a comment

Make location.reload() consistent with faster reload

Project Member Reported by toyoshim@chromium.org, Dec 1 2016

Issue description

Now location.reload() still behaves as a traditional reload.
We will eventually make it consistent with faster reload.

I'd make this change under new field study.

Also, there is room to discuss on the argument for location.reload() that only Firefox implements.
 
Cc: kenjibaheux@chromium.org
Labels: -Pri-3 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52cfbdee4d6c72e941cb316ae9e1d5cc8301b2a4

commit 52cfbdee4d6c72e941cb316ae9e1d5cc8301b2a4
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Dec 09 06:58:41 2016

Mechanical style fixes: History.cpp and Location.cpp

This patch fixes some style errors caused at the Blink style change,
and some long living other style nits.

BUG= 670237 

Review-Url: https://codereview.chromium.org/2553383002
Cr-Commit-Position: refs/heads/master@{#437487}

[modify] https://crrev.com/52cfbdee4d6c72e941cb316ae9e1d5cc8301b2a4/third_party/WebKit/Source/core/frame/History.cpp
[modify] https://crrev.com/52cfbdee4d6c72e941cb316ae9e1d5cc8301b2a4/third_party/WebKit/Source/core/frame/History.h
[modify] https://crrev.com/52cfbdee4d6c72e941cb316ae9e1d5cc8301b2a4/third_party/WebKit/Source/core/frame/Location.cpp

Blocking: 674404
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cd793e6488686201c9099951b7211abfcf5593f

commit 8cd793e6488686201c9099951b7211abfcf5593f
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Dec 15 06:25:19 2016

FasterLocationReload: use ReloadMainResource for JS exposed reloads

Now all reloads triggered by user interfaces are replaced by
ReloadMainResource, but Location.reload() and History.go() still call
the traditional Reload.

This patch changes them to call ReloadMainResource insteads under a
runtime flag. This flag will be wired to a field study flag later.

This is discussed at loading-dev@ in the following thread.
https://groups.google.com/a/chromium.org/d/topic/loading-dev/gD-MPRcfwVA/discussion

BUG= 670237 

Review-Url: https://codereview.chromium.org/2555963003
Cr-Commit-Position: refs/heads/master@{#438766}

[add] https://crrev.com/8cd793e6488686201c9099951b7211abfcf5593f/third_party/WebKit/LayoutTests/http/tests/cache/location-reload.html
[add] https://crrev.com/8cd793e6488686201c9099951b7211abfcf5593f/third_party/WebKit/LayoutTests/http/tests/cache/resources/location-reload-window.html
[modify] https://crrev.com/8cd793e6488686201c9099951b7211abfcf5593f/third_party/WebKit/Source/core/frame/History.cpp
[modify] https://crrev.com/8cd793e6488686201c9099951b7211abfcf5593f/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/8cd793e6488686201c9099951b7211abfcf5593f/third_party/WebKit/Source/core/frame/Location.cpp
[modify] https://crrev.com/8cd793e6488686201c9099951b7211abfcf5593f/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/8cd793e6488686201c9099951b7211abfcf5593f/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 19 2016

Components: UI>Browser>Navigation Blink>Loader
Labels: M-57 OS-All
Status: Started (was: Assigned)
ok, now it's ready for a field trial. I will make a change to enable this by 1:1 on Canary/Dev.
Now server side configuration is setup for a field study.
The feature should be enabled for 50% of Dev and Canary users on m57 and later versions.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84b31e5ea7c346f66228ceb1c38034e8ec8425b6

commit 84b31e5ea7c346f66228ceb1c38034e8ec8425b6
Author: toyoshim <toyoshim@chromium.org>
Date: Mon Jan 23 20:16:24 2017

FasterLocationReload: Update Field Trial Testing Configuration

To setup the field trial to be ready for Beta channel, let me
update the configuration to run tests under the condition that
enables the feature.

BUG= 670237 

Review-Url: https://codereview.chromium.org/2644143004
Cr-Commit-Position: refs/heads/master@{#445459}

[modify] https://crrev.com/84b31e5ea7c346f66228ceb1c38034e8ec8425b6/testing/variations/fieldtrial_testing_config.json

Cc: bmcquade@chromium.org kinuko@chromium.org toyoshim@chromium.org
 Issue 578941  has been merged into this issue.
Blockedon: 702097
Labels: Reload
Now the feature is going to be enabled on the stable.
I will use this bug even for cleanup patches.

Note: the feature is rolled out via experiment-control at m57, and enabled in the code base at m59. Also, old code path will be removed at m59.
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea77fe5f9663714b8458b23dd996279baade45d6

commit ea77fe5f9663714b8458b23dd996279baade45d6
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Mar 16 09:35:11 2017

Disable ReloadCacheControlBrowserTest if PlzNavigate is enabled

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=kinuko@chromium.org
BUG= 671545 ,  670237 

Review-Url: https://codereview.chromium.org/2752073005
Cr-Commit-Position: refs/heads/master@{#457384}

[modify] https://crrev.com/ea77fe5f9663714b8458b23dd996279baade45d6/content/browser/loader/reload_cache_control_browsertest.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec7d62a479fe6625a2a20295e346bfe92d42417c

commit ec7d62a479fe6625a2a20295e346bfe92d42417c
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Mar 17 05:18:18 2017

FasterLocationReload: remove the field trial flag

Now that the feature is enabled by default on the stable m57
and the flag in the code base is enabled by default on trunk,
remove the field trial flag and old code path.

BUG= 670237 

Review-Url: https://codereview.chromium.org/2752203002
Cr-Commit-Position: refs/heads/master@{#457693}

[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/chrome/app/generated_resources.grd
[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/chrome/browser/about_flags.cc
[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/content/child/runtime_features.cc
[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/content/public/common/content_features.cc
[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/content/public/common/content_features.h
[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/third_party/WebKit/Source/core/frame/History.cpp
[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/third_party/WebKit/Source/core/frame/Location.cpp
[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp
[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/ec7d62a479fe6625a2a20295e346bfe92d42417c/third_party/WebKit/public/web/WebRuntimeFeatures.h

Status: Fixed (was: Started)
Now the feature is enabled for all users on all channels.

Sign in to add a comment