New issue
Advanced search Search tips

Issue 670196 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 669580

Blocking:
issue 612701
issue 670232



Sign in to add a comment

Faster Reload: consider to use ReloadMainResource for all WebFrame:: reload users

Project Member Reported by toyoshim@chromium.org, Dec 1 2016

Issue description

https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrame.h

realod() and reloadwithOverrideURL() take WebFrameLoadType, and still some callers use ::Reload rather than ::ReloadMainResource.

Let check these callers, and use ::ReloadMainResource if it's reasonable.
 
Blocking: 612701
Blocking: 670232
Caller list:
src/chrome/renderer/content_settings_observer.cc	 (1 occurrence)
 448 OnReloadFrame()render_frame()->GetWebFrame()->reload();

src/chrome/renderer/net/net_error_helper.cc	 (1 occurrence)
 316 ReloadPage(bypass_cache)render_frame()->GetWebFrame()->reload(

src/content/renderer/render_frame_impl.cc	 (1 occurrence)
 2263 OnReload(bypass_cache)frame_->reload(bypass_cache ? WebFrameLoadType::ReloadBypassingCache

src/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp	 (2 occurrences)
 141 reloadFrame(frame)frame->reload(WebFrameLoadType::Reload);

 146 reloadFrameIgnoringCache(frame)frame->reload(WebFrameLoadType::ReloadBypassingCache);
src/third_party/WebKit/Source/web/tests/WebFrameTest.cpp	 (1 occurrence)
 4089 TestBody()webViewHelper.webView()->mainFrame()->reload(
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b557832fd015fb056585ed3798cc2a626fff076

commit 7b557832fd015fb056585ed3798cc2a626fff076
Author: toyoshim <toyoshim@chromium.org>
Date: Tue Dec 06 13:48:55 2016

Use ReloadMainResource for per-frame reload

Now NavigationController uses ReloadMainResource by default.
Let's make other use cases aligned to make Chrome consistent.

BUG= 670196 

Review-Url: https://codereview.chromium.org/2553053002
Cr-Commit-Position: refs/heads/master@{#436581}

[modify] https://crrev.com/7b557832fd015fb056585ed3798cc2a626fff076/chrome/renderer/content_settings_observer.cc
[modify] https://crrev.com/7b557832fd015fb056585ed3798cc2a626fff076/content/renderer/render_frame_impl.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8f59c2e1fc7ff7c45e006194547364deec4e2eb

commit c8f59c2e1fc7ff7c45e006194547364deec4e2eb
Author: toyoshim <toyoshim@chromium.org>
Date: Wed Dec 07 02:03:30 2016

WebFrameTest: use ReloadMainResource instead of Reload

Now ReloadMainResource is used by default for reload operations.
Let make all callers to use ReloadMainResource instead of Reload
to be aligned with other use cases, and make Blink consistent.

Once all callers are modified, I'd merge ReloadMainResource to Reload
and make Reload behave as current ReloadMainResource does.

BUG= 670196 

Review-Url: https://codereview.chromium.org/2555623003
Cr-Commit-Position: refs/heads/master@{#436831}

[modify] https://crrev.com/c8f59c2e1fc7ff7c45e006194547364deec4e2eb/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
[modify] https://crrev.com/c8f59c2e1fc7ff7c45e006194547364deec4e2eb/third_party/WebKit/Source/web/tests/FrameTestHelpers.h
[modify] https://crrev.com/c8f59c2e1fc7ff7c45e006194547364deec4e2eb/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Do code search again.

WebFrame::reload()
  no callers use WebFrameLoadType::Reload

WebFrame::reloadWithOverrideURL()
  WebFrameTest.cpp line 4132, 4143

So, I'd remove WebFrameTest use cases, and drop default argument from the reload.
Eventually, I'd deprecate current Reload and make it behaves as ReloadMainResource to merge them.

At this point, we still have internal use cases for Reload (i.e., at least we should finish migrating location.reload() to use ReloadMainResource). So, I do not do it in this crbug.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b39f0247b96125c94a71dd3323ea16b8deac182

commit 4b39f0247b96125c94a71dd3323ea16b8deac182
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Dec 15 04:27:17 2016

FasterReload: remove default WebFrameLoadType from WebFrame::reload*

Now, there are two callses that use WebFrameLoadType::Reload to call
WebFrame::reloadWithOverrideURL(). These callers can be modified to use
WebFrameLoadType::ReloadMainResoure insteads.

Also, this change removes default argument from WebFrame::reload() and
WebFrame::reloadWithOverrideURL() so to encourage using a right reload
type for each caller respectively. Also this will be better in terms of
coding style since default argument for virtual method is not recommended
in chromium.

BUG= 670196 

Review-Url: https://codereview.chromium.org/2567983008
Cr-Commit-Position: refs/heads/master@{#438737}

[modify] https://crrev.com/4b39f0247b96125c94a71dd3323ea16b8deac182/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/4b39f0247b96125c94a71dd3323ea16b8deac182/third_party/WebKit/public/web/WebFrame.h

Status: Fixed (was: Assigned)
Filed a new bug for the last piece.
Let me close this as fixed.

Sign in to add a comment