Issue metadata
Sign in to add a comment
|
Regression: Drop-down does not close via tap/touch at chrome://settings
Reported by
jshan...@etouch.net,
Dec 1 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2937.0 (Official Build) 276217cd97923c96f30654e6f459d23983855603-refs/heads/master@{#435110}-32/64 bit OS: Windows 10 (Touch device) Steps: 1. Launch Chrome and navigate to chrome://settings 2. Tap/touch on Drop-down under "Search" twice and observe. Actual: On second tap/touch, drop down does not close Expected: On second tap/touch, drop down should close This is a regression issue broken in M-57, below is bisect info. Good build: 57.0.2931.0 Bad build: 57.0.2933.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/d4ddbd0f740b9916ac1d823343544312fb7fbeaf..6255265704c19083d47fb1500ee869f872dd546d?pretty=fuller&n=100 Suspecting: r434330 ? Please help to re-assign if your change is not the cause for this issue. Note: This is touch device specific issue, same works fine via mouse click
,
Dec 5 2016
sahel@: Could you please take a look at this. Thank you!
,
Dec 6 2016
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59dc4be5b2da772c3994506261f4044713198791 commit 59dc4be5b2da772c3994506261f4044713198791 Author: sahel <sahel@chromium.org> Date: Fri Dec 09 21:05:24 2016 Drop-down closes via tap/touch again. The drop-down list closes on a GestureTapDown, and the next GestureTap cannot open the same list. The regression was because of the following cl: https://codereview.chromium.org/2517253002/ BUG= 670185 , 569092 Test=LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html Review-Url: https://codereview.chromium.org/2558113002 Cr-Commit-Position: refs/heads/master@{#437650} [modify] https://crrev.com/59dc4be5b2da772c3994506261f4044713198791/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations-expected.txt [modify] https://crrev.com/59dc4be5b2da772c3994506261f4044713198791/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html [modify] https://crrev.com/59dc4be5b2da772c3994506261f4044713198791/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/59dc4be5b2da772c3994506261f4044713198791/third_party/WebKit/Source/web/WebViewImpl.h
,
Dec 9 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Dec 1 2016