New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670147 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
gone, assign your bugs elsewhere :)
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-XR
Proj-XR-VR



Sign in to add a comment

Add VR Shell unit tests to Android Tryservers

Project Member Reported by bsheedy@chromium.org, Dec 1 2016

Issue description

We're releasing WebVR (which shares a number of components and thus unit tests with VR Shell) in M56, and we want to make sure nothing gets broken by a late merge. Going forward, we'd also like breaking changes to be caught in the commit queue.

The unit tests were recently enabled on the chromium.android master in https://codereview.chromium.org/2521883003/, and have been stable since. They also ran on our VR tester FYI bot for a long time without issue.
 
Components: UI>Browser>VR
Components: -Infra>Platform>Buildbot>TryServer Infra>Client>Android
Owner: stip@chromium.org
Status: Assigned (was: Untriaged)
Oh, so Android tests are added to the tryservers/commit queue via the chromium.android master's .json file? I was under the impression that it was handled somewhere outside the main repo or in a different way since there wasn't a testing/buildbot/tryserver.chromium.android.json file.
Yeah, all tryservers are configured to mirror exactly one non-tryserver bot. They just copy the config of their main waterfall bot. We have two android CQ bots:
 - linux_android_rel_ng mirrors 'Android Tests' and is configured with testing/buildbot/chromium.linux.json (currently under a capacity crunch, we're trying to hold off on adding more tests to this bot)
 - android_n5x_swarming_rel mirrors 'Android N5X Swarm Builder' and is configured with testing/buildbot/chromium.android.json


It's on my plate to clean a lot of that up...
#5: clean up what exactly?
Mainly putting all android bots on chromium.linux onto chromium.android and giving them saner names
Ah, ok. sgtm
Labels: VR-Test
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6539dc7b85800f035f1a14e06653497a45aab0c

commit d6539dc7b85800f035f1a14e06653497a45aab0c
Author: stip <stip@chromium.org>
Date: Wed Jan 11 00:51:09 2017

Add vr_shell_unittests to ansr.

BUG= 670147 

Review-Url: https://codereview.chromium.org/2549393004
Cr-Commit-Position: refs/heads/master@{#442744}

[modify] https://crrev.com/d6539dc7b85800f035f1a14e06653497a45aab0c/testing/buildbot/chromium.android.json

Status: Fixed (was: Assigned)
Closing, as the tests seem to be running fine on tryserver.chromium.android.android_n5x_swarming_rel.

Sign in to add a comment