New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 670140 link

Starred by 1 user
Status: Fixed
Owner:
█ w...@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

AVDACodecAllocator shouldn't tolerate threads failing to start

Project Member Reported by w...@chromium.org, Dec 1 2016 
No other code in Chrome does this, and it complicates the surrounding code.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/997e9e7f24cf2c6b8433bbfeedeeaf5a6b7c6d13

commit 997e9e7f24cf2c6b8433bbfeedeeaf5a6b7c6d13
Author: watk <watk@chromium.org>
Date: Thu Dec 01 23:29:34 2016

media: AVDACodecAllocator now fails if threads don't start

Previously AVDACodecAllocator tried to gracefully handle threads failing
to start. To simplify its contract, now it considers threads failing to
to be an error.

BUG= 670140 
TEST=existing tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2540393002
Cr-Commit-Position: refs/heads/master@{#435756}

[modify] https://crrev.com/997e9e7f24cf2c6b8433bbfeedeeaf5a6b7c6d13/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/997e9e7f24cf2c6b8433bbfeedeeaf5a6b7c6d13/media/gpu/avda_codec_allocator.cc
[modify] https://crrev.com/997e9e7f24cf2c6b8433bbfeedeeaf5a6b7c6d13/media/gpu/avda_codec_allocator.h
[modify] https://crrev.com/997e9e7f24cf2c6b8433bbfeedeeaf5a6b7c6d13/media/gpu/avda_codec_allocator_unittest.cc

Comment 2 by w...@chromium.org, Jan 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment