New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670139 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
HSTS-Preload


Sign in to add a comment

Preload list JSON is out of sync with .h

Project Member Reported by lgar...@chromium.org, Dec 1 2016

Issue description

Regenerating the binary data on tip of tree results in a binary change in the .h, but the script has always been deterministic before – so this shouldn't happen unless I committed a binary that was out of sync with the JSON.

I haven't actually found a discrepancy yet, so I'm still investigating.
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe53f360120731ef49a48a314f843694e40a8659

commit fe53f360120731ef49a48a314f843694e40a8659
Author: Lucas Garron <lgarron@chromium.org>
Date: Sat Dec 03 01:03:50 2016

Re-generate transport_security_state.h

Normally, regenerating this file is deterministic. I can't find a discrepancy between the JSON and the behaviour of the generated data, but this updates the .h so we can debug without blocking further changes right now.

BUG= 670139 
TBR=palmer@chromium.org

Review URL: https://codereview.chromium.org/2549903003 .

Cr-Commit-Position: refs/heads/master@{#436114}

[modify] https://crrev.com/fe53f360120731ef49a48a314f843694e40a8659/net/http/transport_security_state_static.h

Status: WontFix (was: Started)

Comment 4 by mart...@martijnc.be, Mar 13 2017

This appears to have happened again. Running the generator on ToT results in a change to the binary data in the .h file.

Likely due to [1] missing the .h diff.

[1] https://chromium.googlesource.com/chromium/src/+/21f26e967e50357e2e251249a51b37920dff6236%5E%21/net/http/transport_security_state_static.json
Status: Assigned (was: WontFix)
yargh. I was pretty sure I ran it for both the M58 removals and additions, but there are a couple of reasons I might not have (e.g. rebasing mistake, other git mixups, or just plain forgetting). Thanks for pointing this out.
Status: WontFix (was: Assigned)
Actually, let's make that a separate issue:  Issue 701148 

Sign in to add a comment