Preload list JSON is out of sync with .h |
|||
Issue descriptionRegenerating the binary data on tip of tree results in a binary change in the .h, but the script has always been deterministic before – so this shouldn't happen unless I committed a binary that was out of sync with the JSON. I haven't actually found a discrepancy yet, so I'm still investigating.
,
Dec 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe53f360120731ef49a48a314f843694e40a8659 commit fe53f360120731ef49a48a314f843694e40a8659 Author: Lucas Garron <lgarron@chromium.org> Date: Sat Dec 03 01:03:50 2016 Re-generate transport_security_state.h Normally, regenerating this file is deterministic. I can't find a discrepancy between the JSON and the behaviour of the generated data, but this updates the .h so we can debug without blocking further changes right now. BUG= 670139 TBR=palmer@chromium.org Review URL: https://codereview.chromium.org/2549903003 . Cr-Commit-Position: refs/heads/master@{#436114} [modify] https://crrev.com/fe53f360120731ef49a48a314f843694e40a8659/net/http/transport_security_state_static.h
,
Dec 16 2016
,
Mar 13 2017
This appears to have happened again. Running the generator on ToT results in a change to the binary data in the .h file. Likely due to [1] missing the .h diff. [1] https://chromium.googlesource.com/chromium/src/+/21f26e967e50357e2e251249a51b37920dff6236%5E%21/net/http/transport_security_state_static.json
,
Mar 13 2017
yargh. I was pretty sure I ran it for both the M58 removals and additions, but there are a couple of reasons I might not have (e.g. rebasing mistake, other git mixups, or just plain forgetting). Thanks for pointing this out.
,
Mar 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by lgar...@chromium.org
, Dec 1 2016