New issue
Advanced search Search tips

Issue 670128 link

Starred by 5 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR shell: Handle outgoing intents in a way that optimizes user experience

Project Member Reported by ddorwin@chromium.org, Dec 1 2016

Issue description

Outgoing intents could cause unexpected results for users wearing a headset. For example, going to a non-Daydream-ready app that doesn't display properly in the headset.

When in a Daydream headset, transitioning to a Daydream app makes sense.

In other cases, it might be better to navigate to the web page instead so the user can remain in the headset. Alternatively, we could offer the user the opportunity to remove the headset and wait for a response before continuing.
 
Issue 641466 has been merged into this issue.
 Issue 673525  has been merged into this issue.
Components: Mobile>Intents
Labels: -Type-Feature VR-DF Type-Bug
 Issue 673525  contains specific repro steps for an example case. Changing this to a bug given the poor user experience.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f9c06b2bc825d86db2fbc2b21dc35fd453f8b69

commit 1f9c06b2bc825d86db2fbc2b21dc35fd453f8b69
Author: tiborg <tiborg@google.com>
Date: Thu Jan 19 19:23:03 2017

VR Shell does not redirect to another app while in VR mode.

- VrShellImpl sets a custom TabRedirectHandler implementation to the tab displaying the vr shell.
- The custom TabRedirectHandler implementation prevents any redirect to another app, e.g. when clicking on youtube.com.

BUG=670128

Review-Url: https://codereview.chromium.org/2641933002
Cr-Commit-Position: refs/heads/master@{#444814}

[modify] https://crrev.com/1f9c06b2bc825d86db2fbc2b21dc35fd453f8b69/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/1f9c06b2bc825d86db2fbc2b21dc35fd453f8b69/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Owner: tiborg@chromium.org
Owner: ----
Tibor's patch was the first step towards addressing this issue, but more work is needed for the 'optimal' experience. Namely, if a url would direct to an app that supports VR, we should allow chrome to launch that app in VR rather than just rejecting.
Labels: -Pri-2 Pri-3
Labels: -VR-DF
Labels: VRB-Next-Triage
Labels: -Pri-3 VRB-SVR-Only Pri-2

Comment 11 by samdrazin@chromium.org, Jan 18 (5 days ago)

Labels: -VRB-Next-Triage -VRB-SVR-Only VR-B-SVR-Only

Comment 12 by elalish@google.com, Yesterday (30 hours ago)

Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature
Looking at the last comment, what's left here doesn't look like a bug anymore. We'd need a list of VR apps that can be launched from websites to increase priority.

Comment 13 by samdrazin@chromium.org, Yesterday (29 hours ago)

Labels: -VR-B-SVR-Only

Sign in to add a comment