Provide accessibility labels for "close" buttons in the list of tabs |
||||||||
Issue descriptionChrome Version: latest dev build OS: Android (any) What steps will reproduce the problem? (1) Launch TalkBack, settings -> Accessibility -> TalkBack. (2) Open Chrome, then load a few tabs so that the "x tabs" button appears in the action bar. (3) Tap on the "tabs list" button in the action bar and swipe between entries in the list. Observe how "close" buttons are spoken. What is the expected result? Each "close" button should tell the user which tab it is closing. What happens instead? The label for the "close" button simply says "close". Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Mar 27 2017
,
Apr 21 2017
,
Apr 21 2017
,
Aug 7 2017
,
Aug 11 2017
@tedchoc, could you delegate this to someone?
,
Aug 11 2017
huayinz - can you take a look? @dmazzoni, @lpalmaro I have a more general question about this request though. What is the normal Android pattern here? If you focus the search box in GSA, do the up arrows to refine the search say "Refine <query>", do the stars in Gmail say "Star <title of email>"? I think if we did this we'd likely be quite inconsistent within Chrome itself. The history page has trash cans, but do we say "Delete <URL/title>", or bookmarks with the menu button. It would be good to be uniform in our handling of list actions in my opinion, but then again, this could be more critical than the other items I mentioned and therefore should have more information.
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e478f74685cfc037c63a87ab25745a52ae251220 commit e478f74685cfc037c63a87ab25745a52ae251220 Author: Becky Zhou <huayinz@chromium.org> Date: Tue Aug 15 22:36:59 2017 Add tab title to accessibility tab model item close button Bug: 670124 Change-Id: If1c32ae0755518655674f3b46aaa7ee8462e4f6a Reviewed-on: https://chromium-review.googlesource.com/614567 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#494577} [modify] https://crrev.com/e478f74685cfc037c63a87ab25745a52ae251220/chrome/android/java/res/layout/accessibility_tab_switcher_list_item.xml [modify] https://crrev.com/e478f74685cfc037c63a87ab25745a52ae251220/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java [modify] https://crrev.com/e478f74685cfc037c63a87ab25745a52ae251220/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java [modify] https://crrev.com/e478f74685cfc037c63a87ab25745a52ae251220/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java [modify] https://crrev.com/e478f74685cfc037c63a87ab25745a52ae251220/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/e478f74685cfc037c63a87ab25745a52ae251220/chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperTest.java
,
Aug 16 2017
,
Aug 22 2017
Re-tested on M62-62.0.3193.0 - now reading the tab title, while closing the tab(using X). |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rsgav...@chromium.org
, Jan 25 2017