New issue
Advanced search Search tips

Issue 670122 link

Starred by 1 user
Status: Fixed
Owner:
seanmccullough@chromium.org
Closed: May 2017
Cc:
seanmccullough@chromium.org
vadimsh@chromium.org
martiniss@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

refactor SoM into separate go package

Project Member Reported by seanmccullough@chromium.org, Dec 1 2016 
Should probably be something like:

infra/appengine/sheriff-o-matic/som
  admin    // admin settings 
  clients  // wrappers for talking to gitiles etc
  handlers // pubsub, api http request handlers
  model    // structs we serialize for datastore, json for client etc
  som      // still holds main.go, http handler for /, registers routes etc
  ...
  
Right now it's all wadded up into one package with no clear separation between these concerns.

Comment 1 by martiniss@chromium.org, Dec 1 2016

Cc: vadimsh@chromium.org
I think go app engine wants a particular directory structure. So I think everything would have to be in the same folder.

Agree with the idea though.

Comment 2 by vadimsh@chromium.org, Dec 1 2016 

The "entry" point module (the module that defines init() where everything is setup and that contains app.yaml) should have no submodules. But it can reference other modules (its siblings). For that reason I structure apps like:

/app/
  module1/
    module1_1/
    ...
  module2/
  ...
  frontend/   # entry point for 'default' GAE module
    main.go   # imports module1 and module2
    app.yaml
    cron.yaml
    ...
  backend/    # entry point for 'backend' GAE module, if present
    main.go
    module-backend.yaml

Some reasoning is explained here: https://github.com/luci/luci-go/tree/master/examples/appengine/helloworld_standard#code-structure

(Maybe there's a better way...)

Comment 3 by seanmccullough@chromium.org, Dec 1 2016 

Yeesh. Ok how about this? the appengine/sheriff-o-matic/... stuff is stripped down to basically app.yaml, static resources, and a main.go that just registers handlers. The rest of the code lives in a path that is outside of infra/go/src/infra/appengine.

ex:

main.go, app.yaml, html, js etc still live in infra/go/src/infra/appengine/sheriff-o-matic

All the other s-o-m Go packages go into (note the lack of /appengine/):
infra/go/src/infra/sheriff-o-matic 
  /admin
  /clients
  /handlers
  etc...

main.go is package main and has init(). 
It imports the rest of the som app code like so:

import "infra/sheriff-o-matic/admin"

Comment 4 by seanmccullough@chromium.org, May 23 2017

Owner: seanmccullough@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9c0644b65dd1ee34f4274326603e34d8ce1538b9

commit 9c0644b65dd1ee34f4274326603e34d8ce1538b9
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Fri May 26 18:28:21 2017

[som] Split GAE app into minimal frontend and sibling go packages.

This only breaks things into frontend/ and som/

frontend/main.go basically just registers handlers that are defined
in sheriff-o-matic/som. We can subdivide these further into more
specific packages in later CLs if need be.

Had to do some funny stuff with the Makefiles FYI. There's probably
a better way to deal with this setup so I'm all ears.

Bug:  670122 
Change-Id: I26c60e2f4240fa0999345f63efda788381b1e5c8
Reviewed-on: https://chromium-review.googlesource.com/513244
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>

[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-marked-element/som-marked-element.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/bower.json
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/crrev.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/images/jparent-jump.gif
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-marked-element/som-marked-element.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-annotations-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-rev-range/som-rev-range.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/alerts-data.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/images/README.md
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/wct.conf.json
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/main_test.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-trooper-failure/som-extension-trooper-failure.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-input-styles.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-examine/som-examine.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-cros-failure/som-extension-cros-failure.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/urlfmt.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-extension-cros-failure-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-build-failure/som-extension-build-failure.html
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/trees.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-swarming-bots/som-swarming-bots.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/package.json
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/admin_test.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-swarming-bots-test.html
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/main.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.html
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/admin.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-item-test.html
[delete] https://crrev.com/c4a324f4aca90dec0f983e0d7992bac3da64fb65/go/src/infra/appengine/sheriff-o-matic/index.html
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/Makefile
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-master-restarts/som-master-restarts.js
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/Makefile
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/annotations.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/app.yaml
[delete] https://crrev.com/c4a324f4aca90dec0f983e0d7992bac3da64fb65/go/src/infra/appengine/sheriff-o-matic/som/main.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-tree-status/som-tree-status.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-annotation-manager-behavior-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-rev-range/som-rev-range.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-webkit-tests/som-webkit-tests.js
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/layout_tests_test.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-drawer-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/cron.yaml
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-test-expectations-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-master-restarts-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-marked-element-test.html
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/main_test.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-webkit-tests/som-webkit-tests.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-tree-status-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-type-behavior.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-extension-build-failure-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/index.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotation-manager-behavior.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-webkit-tests-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-examine-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-expectations/som-test-expectations.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/scripts/clientmon.js
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/clientmon.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-view-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-rev-range-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-cros-failure/som-extension-cros-failure.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-swarming-bots/som-swarming-bots.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-master-restarts/som-master-restarts.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-bug-queue-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-settings/som-settings.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/images/favicon.ico
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-expectations/som-test-expectations.html
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/analyze.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-examine/som-examine.js
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/alerts.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-tree-status/som-tree-status.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/index.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-trooper-failure/som-extension-trooper-failure.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-settings/som-settings.html
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/layout_tests.go
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/frontend.infra_testing
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/analyze_test.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/index.yaml
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-build-failure/som-extension-build-failure.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/images/findit.png
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/pages/som-rotation-calendar.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/pages/som-help.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-app-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/access-denied.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-linkify-behavior.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.js
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/bugqueue.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-header-styles.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/static/google03daf1850f438695.html
[delete] https://crrev.com/c4a324f4aca90dec0f983e0d7992bac3da64fb65/go/src/infra/appengine/sheriff-o-matic/access-denied.html
Project Member

Comment 6 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9c0644b65dd1ee34f4274326603e34d8ce1538b9

commit 9c0644b65dd1ee34f4274326603e34d8ce1538b9
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Fri May 26 18:28:21 2017

[som] Split GAE app into minimal frontend and sibling go packages.

This only breaks things into frontend/ and som/

frontend/main.go basically just registers handlers that are defined
in sheriff-o-matic/som. We can subdivide these further into more
specific packages in later CLs if need be.

Had to do some funny stuff with the Makefiles FYI. There's probably
a better way to deal with this setup so I'm all ears.

Bug:  670122 
Change-Id: I26c60e2f4240fa0999345f63efda788381b1e5c8
Reviewed-on: https://chromium-review.googlesource.com/513244
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>

[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-marked-element/som-marked-element.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/bower.json
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/crrev.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/images/jparent-jump.gif
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-marked-element/som-marked-element.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-annotations-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-rev-range/som-rev-range.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/alerts-data.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/images/README.md
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/wct.conf.json
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/main_test.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-trooper-failure/som-extension-trooper-failure.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-input-styles.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-examine/som-examine.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-cros-failure/som-extension-cros-failure.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/urlfmt.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-extension-cros-failure-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-build-failure/som-extension-build-failure.html
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/trees.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-swarming-bots/som-swarming-bots.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/package.json
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/admin_test.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-swarming-bots-test.html
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/main.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.html
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/admin.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-item-test.html
[delete] https://crrev.com/c4a324f4aca90dec0f983e0d7992bac3da64fb65/go/src/infra/appengine/sheriff-o-matic/index.html
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/Makefile
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-master-restarts/som-master-restarts.js
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/Makefile
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/annotations.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/app.yaml
[delete] https://crrev.com/c4a324f4aca90dec0f983e0d7992bac3da64fb65/go/src/infra/appengine/sheriff-o-matic/som/main.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-tree-status/som-tree-status.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-annotation-manager-behavior-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-rev-range/som-rev-range.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-webkit-tests/som-webkit-tests.js
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/layout_tests_test.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-drawer-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/cron.yaml
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-test-expectations-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-master-restarts-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-marked-element-test.html
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/main_test.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-webkit-tests/som-webkit-tests.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-tree-status-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-type-behavior.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-extension-build-failure-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/index.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotation-manager-behavior.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-webkit-tests-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-drawer/som-drawer.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-examine-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-expectations/som-test-expectations.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/scripts/clientmon.js
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/clientmon.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-view-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-rev-range-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-cros-failure/som-extension-cros-failure.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-swarming-bots/som-swarming-bots.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-master-restarts/som-master-restarts.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-bug-queue-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-settings/som-settings.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-app/som-app.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/images/favicon.ico
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-expectations/som-test-expectations.html
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/analyze.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-examine/som-examine.js
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/alerts.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-tree-status/som-tree-status.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/index.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-trooper-failure/som-extension-trooper-failure.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-settings/som-settings.html
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/layout_tests.go
[add] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/frontend.infra_testing
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/analyze_test.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/index.yaml
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-extension-build-failure/som-extension-build-failure.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/images/findit.png
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/pages/som-rotation-calendar.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/pages/som-help.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-app-test.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/access-denied.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-linkify-behavior.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.js
[modify] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/som/bugqueue.go
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-bug-queue/som-bug-queue.js
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-header-styles.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.html
[rename] https://crrev.com/9c0644b65dd1ee34f4274326603e34d8ce1538b9/go/src/infra/appengine/sheriff-o-matic/frontend/static/google03daf1850f438695.html
[delete] https://crrev.com/c4a324f4aca90dec0f983e0d7992bac3da64fb65/go/src/infra/appengine/sheriff-o-matic/access-denied.html

Comment 7 by seanmccullough@chromium.org, May 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment