New issue
Advanced search Search tips

Issue 670119 link

Starred by 1 user
Status: Fixed
Owner:
dougarnett@chromium.org
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

[OfflinePages] Restart immediate background loading upon network connection

Project Member Reported by dougarnett@chromium.org, Dec 1 2016 
Currently the RequestCoordinator will not start immediate processing
or will not continue processing if there is no network connection. It
can be quite delay to resume processing via the GcmNetworkManager so
while chrome is still resident, use an in-memory network observer to
detect when connection returns and start processing again (at least for
immediate mode processing).
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7103c6cef4c8ed86a090e605e9817d1852452dc2

commit 7103c6cef4c8ed86a090e605e9817d1852452dc2
Author: dougarnett <dougarnett@chromium.org>
Date: Fri Dec 02 21:51:48 2016

[OfflinePages] Restarts immediate processing if stopped due to no net

Adds a ConnectionNotifier helper class to be able to learn when we get
connected and uses it in the Coordinator to try immediate start when
we get connected after stopping because we had no connection.

This is a memory-only network observer so only in effect if chrome stays
resident in memory.  Otherwise, we still have the GcmNetworkManager
scheduler as a fallback.

BUG= 670119 

Review-Url: https://codereview.chromium.org/2546433004
Cr-Commit-Position: refs/heads/master@{#436040}

[modify] https://crrev.com/7103c6cef4c8ed86a090e605e9817d1852452dc2/components/offline_pages/background/BUILD.gn
[add] https://crrev.com/7103c6cef4c8ed86a090e605e9817d1852452dc2/components/offline_pages/background/connection_notifier.cc
[add] https://crrev.com/7103c6cef4c8ed86a090e605e9817d1852452dc2/components/offline_pages/background/connection_notifier.h
[modify] https://crrev.com/7103c6cef4c8ed86a090e605e9817d1852452dc2/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/7103c6cef4c8ed86a090e605e9817d1852452dc2/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/7103c6cef4c8ed86a090e605e9817d1852452dc2/components/offline_pages/background/request_coordinator_unittest.cc

Comment 2 by dougarnett@chromium.org, Dec 5 2016

Status: Fixed (was: Assigned)

Comment 3 by dougarnett@chromium.org, Dec 6 2016

Labels: M-56 Merge-Request-56

Comment 4 by dimu@chromium.org, Dec 6 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 6 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3649e1f0d1448d159c37fb3209a6814dc79569a3

commit 3649e1f0d1448d159c37fb3209a6814dc79569a3
Author: Pete Williamson <petewil@chromium.org>
Date: Tue Dec 06 18:50:39 2016

[OfflinePages] Restarts immediate processing if stopped due to no net

Adds a ConnectionNotifier helper class to be able to learn when we get
connected and uses it in the Coordinator to try immediate start when
we get connected after stopping because we had no connection.

This is a memory-only network observer so only in effect if chrome stays
resident in memory.  Otherwise, we still have the GcmNetworkManager
scheduler as a fallback.

BUG= 670119 

Review-Url: https://codereview.chromium.org/2546433004
Cr-Commit-Position: refs/heads/master@{#436040}
(cherry picked from commit 7103c6cef4c8ed86a090e605e9817d1852452dc2)

Review URL: https://codereview.chromium.org/2556613003 .

Cr-Commit-Position: refs/branch-heads/2924@{#358}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/3649e1f0d1448d159c37fb3209a6814dc79569a3/components/offline_pages/background/BUILD.gn
[add] https://crrev.com/3649e1f0d1448d159c37fb3209a6814dc79569a3/components/offline_pages/background/connection_notifier.cc
[add] https://crrev.com/3649e1f0d1448d159c37fb3209a6814dc79569a3/components/offline_pages/background/connection_notifier.h
[modify] https://crrev.com/3649e1f0d1448d159c37fb3209a6814dc79569a3/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/3649e1f0d1448d159c37fb3209a6814dc79569a3/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/3649e1f0d1448d159c37fb3209a6814dc79569a3/components/offline_pages/background/request_coordinator_unittest.cc
►

Sign in to add a comment