New issue
Advanced search Search tips

Issue 670093 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ERR_ICANN_NAME_COLLISION is not returned when using the builtin (async) DNS resolver

Project Member Reported by eroman@chromium.org, Nov 30 2016

Issue description

When the system proc based DNS resolver returns 127.0.53.53, we fail with ERR_ICANN_NAME_COLLISION.

This is implemented by HostResolverImpl.

However this is not working when you use the async/builtin DNS resolver.
 
Nice catch!
(I sourced this from https://bugs.chromium.org/p/chromium/issues/detail?id=479620#c52, where this issue can be seen in a log)

Comment 3 by eroman@chromium.org, Dec 10 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cd87b66f47aa7f08c09eab08f9c6303dd107766

commit 0cd87b66f47aa7f08c09eab08f9c6303dd107766
Author: eroman <eroman@chromium.org>
Date: Wed Dec 14 19:13:45 2016

Misc HostResolverImpl refactors.

 * Don't cache ERR_ICANN_NAME_COLLISION under task-based resolver (to
   match proc-based resolver)

 * Save an empty address list in cache for ERR_ICANN_NAME_COLLISION
   entries (rather than the address list originally resolved).

BUG= 670093 

Review-Url: https://codereview.chromium.org/2577503003
Cr-Commit-Position: refs/heads/master@{#438575}

[modify] https://crrev.com/0cd87b66f47aa7f08c09eab08f9c6303dd107766/net/dns/host_resolver_impl.cc
[modify] https://crrev.com/0cd87b66f47aa7f08c09eab08f9c6303dd107766/net/dns/host_resolver_impl_unittest.cc

Comment 6 by eroman@chromium.org, Dec 14 2016

Status: Fixed (was: Started)

Sign in to add a comment