New issue
Advanced search Search tips

Issue 670090 link

Starred by 1 user
Status: Fixed
Owner:
klausw@chromium.org
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-VR
Proj-XR



Sign in to add a comment

WebVR reporting incorrect right eye dimensions

Project Member Reported by klausw@chromium.org, Nov 30 2016 
Due to a typo, the eye dimensions reported to the application accidentally set the right eye's renderWidth to renderHeight. This is a Javascript-visible API.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d15259836e63edf641b563e6dc7abaf15f51507e

commit d15259836e63edf641b563e6dc7abaf15f51507e
Author: klausw <klausw@chromium.org>
Date: Wed Nov 30 23:35:18 2016

WebVR: fix incorrect renderWidth for the right eye

BUG= 670090 

Review-Url: https://codereview.chromium.org/2544503003
Cr-Commit-Position: refs/heads/master@{#435476}

[modify] https://crrev.com/d15259836e63edf641b563e6dc7abaf15f51507e/device/vr/android/gvr/gvr_device.cc

Comment 2 by ddorwin@chromium.org, Nov 30 2016

Labels: Proj-VR-Daydream

Comment 3 by klausw@chromium.org, Nov 30 2016

Labels: Merge-Request-56
Requesting merge into M56

Comment 4 by klausw@chromium.org, Nov 30 2016

Status: Started (was: Untriaged)

Comment 5 by dimu@chromium.org, Dec 1 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Owner: klausw@chromium.org
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 1 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be1bfb6907d7b899a9e290941b5e72039f8ff596

commit be1bfb6907d7b899a9e290941b5e72039f8ff596
Author: Brandon Jones <bajones@chromium.org>
Date: Thu Dec 01 23:46:39 2016

WebVR: fix incorrect renderWidth for the right eye

BUG= 670090 

Review-Url: https://codereview.chromium.org/2544503003
Cr-Commit-Position: refs/heads/master@{#435476}
(cherry picked from commit d15259836e63edf641b563e6dc7abaf15f51507e)

Review URL: https://codereview.chromium.org/2543623004 .

Cr-Commit-Position: refs/branch-heads/2924@{#276}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/be1bfb6907d7b899a9e290941b5e72039f8ff596/device/vr/android/gvr/gvr_device.cc

Comment 7 by bajones@chromium.org, Dec 2 2016

Status: Fixed (was: Started)

Comment 8 by dougman@chromium.org, Feb 6 2018

Labels: M-56

Comment 9 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment