New issue
Advanced search Search tips

Issue 670078 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 673162



Sign in to add a comment

onauxclick content attribute does not appear to be implemented

Project Member Reported by domenic@chromium.org, Nov 30 2016

Issue description

Chrome Version: Version 57.0.2937.0 canary (64-bit) with experimental web platform features enabled

The web platform tests at https://github.com/w3c/web-platform-tests/pull/4269 mostly pass, but the content attribute onauxclick="" does not appear to be implemented.
 

Comment 1 Deleted

domenic@ do you happen to know where in Chrome we define these?
It seems that we are missing this for all the pointerevents as well. But I couldn't find anywhere that has defined this for onclick in the code. 
I'm sorry, I don't. I spent a half-hour spelunking trying to find out to no avail, so I'm very curious with what the eventual answer is!
Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 6 2016

Can we merge this into 56?

Comment 7 by mustaq@chromium.org, Dec 12 2016

Blocking: 673162
Labels: ReleaseBlock-Beta M-56
Labels: Merge-Request-56
Status: Started (was: Fixed)

Comment 10 by dimu@chromium.org, Dec 12 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 12 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/668b73e39142679a1edda6a7415da708ad349269

commit 668b73e39142679a1edda6a7415da708ad349269
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Mon Dec 12 16:52:09 2016

Add onauxclick and onpointer* as content attribute

onauxclick and onpointer* attributes were missing
from the content attributes after those features
were added. This CL adds those.

BUG= 670078 

Review-Url: https://codereview.chromium.org/2554433003
Cr-Commit-Position: refs/heads/master@{#436689}
(cherry picked from commit dcabe3a6d92c6410da0469c2fb02a6b0fd1fe939)

Review-Url: https://codereview.chromium.org/2566213002 .
Cr-Commit-Position: refs/branch-heads/2924@{#456}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/668b73e39142679a1edda6a7415da708ad349269/third_party/WebKit/Source/core/html/HTMLAttributeNames.in
[modify] https://crrev.com/668b73e39142679a1edda6a7415da708ad349269/third_party/WebKit/Source/core/html/HTMLElement.cpp

Status: Fixed (was: Started)
I just merged this to M56. This should be fixed now in both trunk and 65.

Sign in to add a comment