New issue
Advanced search Search tips

Issue 670072 link

Starred by 1 user
Status: Fixed
Owner:
rhalavati@chromium.org
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug



Sign in to add a comment

Updates required for clang scripts.

Project Member Reported by rhalavati@chromium.org, Nov 30 2016 
Two updates are required for clang scripts:
1- generate_wincomp_db.py runs on default build folder out/Debug, it can extend so that it's default input would be this, but other directories can also be specified.
2- run_tool.py can be extended so that it can transfer arguments to the tool that is run.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a237428c35769715e397f8ff0df9d1e223b10345

commit a237428c35769715e397f8ff0df9d1e223b10345
Author: rhalavati <rhalavati@chromium.org>
Date: Thu Dec 01 02:37:03 2016

Clang scripts updates.

Two updates are proposed for clang scripts:
An optional parameter is added to run_tool.py called (tool-param) that is directly passed to the tool that is run.
An optional parameter is added to generate_win_compdb.py to specify the build directory. Its default value is out/Debug so that it won't change the previous behavior.

BUG= 670072 

Review-Url: https://codereview.chromium.org/2542563002
Cr-Commit-Position: refs/heads/master@{#435532}

[modify] https://crrev.com/a237428c35769715e397f8ff0df9d1e223b10345/tools/clang/scripts/generate_win_compdb.py
[modify] https://crrev.com/a237428c35769715e397f8ff0df9d1e223b10345/tools/clang/scripts/run_tool.py

Comment 2 by rhalavati@chromium.org, Jan 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment