New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 670070 link

Starred by 1 user
Status: Fixed
Owner:
█ twif...@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
wifiprefetch-reviews@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Disable precache if data reduction proxy is enabled

Project Member Reported by twif...@chromium.org, Nov 30 2016 
Since precache increases overall data usage on average, we should disable it for users who have explicitly opted into reduced data. It does reduce cellular usage by increasing wifi usage, but that is not a trade-off that is typically associated with the data reduction proxy.

Comment 2 by twif...@chromium.org, Dec 9 2016

Labels: Merge-Request-56

Comment 3 by dimu@chromium.org, Dec 9 2016

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.

Comment 4 by amineer@chromium.org, Dec 14 2016

Labels: -Merge-Review-56 Merge-Approved-56
Merge approved for M56 branch 2924.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 14 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fba7008729b569de970fe88b7823950ff55ca2d

commit 9fba7008729b569de970fe88b7823950ff55ca2d
Author: Devin Mullins <twifkak@google.com>
Date: Wed Dec 14 23:16:11 2016

Disable precache if data_reduction_proxy enabled.

Disable precache if data_reduction_proxy is enabled on this client and the
disable_if_data_reduction_proxy variation parameter is set (non-empty) on the
field trial.

BUG= 670070 

Review-Url: https://codereview.chromium.org/2544613003
Cr-Commit-Position: refs/heads/master@{#437386}
(cherry picked from commit 1190ea49edece62ceb6f1b469364fd026134c695)

Review-Url: https://codereview.chromium.org/2580553002 .
Cr-Commit-Position: refs/branch-heads/2924@{#499}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/9fba7008729b569de970fe88b7823950ff55ca2d/chrome/browser/precache/precache_manager_factory.cc
[modify] https://crrev.com/9fba7008729b569de970fe88b7823950ff55ca2d/components/precache/content/BUILD.gn
[modify] https://crrev.com/9fba7008729b569de970fe88b7823950ff55ca2d/components/precache/content/DEPS
[modify] https://crrev.com/9fba7008729b569de970fe88b7823950ff55ca2d/components/precache/content/precache_manager.cc
[modify] https://crrev.com/9fba7008729b569de970fe88b7823950ff55ca2d/components/precache/content/precache_manager.h
[modify] https://crrev.com/9fba7008729b569de970fe88b7823950ff55ca2d/components/precache/content/precache_manager_unittest.cc

Comment 6 by twif...@chromium.org, Dec 14 2016

Status: Fixed (was: Started)
►

Sign in to add a comment