mash: Verify mash processes are running in desktopui_MashLogin autotest |
||||||
Issue descriptionThe initial version of this test verifies that the browser starts up with --mash. It does this by verifying that autotest can talk to telemetry/devtools. This doesn't mean that chrome actually came up in mash mode, however. It would be much better to verify that we're running mash. This could be: 1) Looking for an existing command line flag in ps (like --is-running-in-mash or --type=mash-child) 2) Looking for log lines like this: INFO:child_process_host.cc(202)] Launched child process pid=28290, instance=3ea05029-9394-4d25-b590-8e2557521350, name=chrome_mash, user_id=505C0EE9-3013-43C0-82B0-A84F50CF8D84 3) Write some kind of one-off telemetry/devtools code that checks whether mash is running This test can't live in the chromium source tree, so I would prefer to look for something that won't change often. sky / rockot - which of these things is most likely to be stable in the long run? Is there something else I could look for?
,
Feb 26 2018
,
Mar 20 2018
When we changed --mash to --enable-features=Mash our tests started falsely passing. This would have caught the problem. I'll take a look.
,
Mar 20 2018
+derat FYI, I'm thinking of doing this in the tast test.
,
Mar 20 2018
Cool! Here's some existing code in the chrome package that may be helpful: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/master/src/chromiumos/tast/local/chrome/proc.go It's used here (for the ui.ChromeCrashLoggedIn and ui.ChromeCrashNotLoggedIn tests): https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/master/src/chromiumos/tast/local/bundles/cros/ui/chromecrash/crash.go I'd strongly advise against making the test be dependent on whether something is logged or not. Logs are for humans, and I've been frustrated in the past when I wanted to make some of powerd's log messages be clearer but couldn't do so easily since there were Autotest-based tests that depended on the existing strings.
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/f89d1c428e4617cada61fe65a18cd99aa5b02459 commit f89d1c428e4617cada61fe65a18cd99aa5b02459 Author: James Cook <jamescook@chromium.org> Date: Wed Mar 21 17:53:28 2018 tast-tests: Ensure mash is running in ui.MashLogin Pass --enable-features=Mash to chrome instead of the deprecated --mash. Verify that at least one chrome process is running with --mash-service-name, which implies that a mash process has started (usually the ash_and_ui process, but that may change). BUG= chromium:670064 TEST=tast ui.MashLogin Change-Id: Icd1b73dc78c8d0feaa6f0a78e9d2c6c6bc26390d Reviewed-on: https://chromium-review.googlesource.com/972154 Commit-Ready: James Cook <jamescook@chromium.org> Tested-by: James Cook <jamescook@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/f89d1c428e4617cada61fe65a18cd99aa5b02459/src/chromiumos/tast/local/chrome/chrome.go [modify] https://crrev.com/f89d1c428e4617cada61fe65a18cd99aa5b02459/src/chromiumos/tast/local/bundles/cros/ui/mash_login.go
,
Mar 22 2018
,
Jun 4 2018
My tast test has been doing this for a while. Now that I get tast failure summary emails, marking done. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jamescook@chromium.org
, Feb 10 2017