New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670058 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Fix "git cl upload" presubmit hooks within /third_party/WebKit/Source/devtools for Windows

Project Member Reported by chenwilliam@chromium.org, Nov 30 2016

Issue description

I found an issue for Windows with our presubmit script which runs various checks (e.g. eslint) before uploading the commit. It relies on node.js and there's a problem locating node.js/npm for Windows which is causing the presubmit checks to fail.
 
Is there an ETA for a fix here? It's not clear how to manually trigger the checks, and debugging Closure Compiler complaints via the trybots is a slow and painful process.

thanks!
Sorry for taking a while - will have a fix soon. Meanwhile, you can run Closure compiler on devtools manually by going to: ~/chromium/src/third_party/WebKit/Source/devtools/scripts and running "python compile_frontend.py".

Thanks.
elawrence@ - I landed a patch that fixes the presubmit hooks for Windows using cmd. There's still some issues left with cygwin so I'll leave this ticket open, but let me know if you still run into any issues.
Status: Fixed (was: Started)
I left this open because of some cygwin issues, but it seems like there's few Chromium developers using cygwin so I'm closing this.

Sign in to add a comment