DevTools: Fix "git cl upload" presubmit hooks within /third_party/WebKit/Source/devtools for Windows |
||
Issue descriptionI found an issue for Windows with our presubmit script which runs various checks (e.g. eslint) before uploading the commit. It relies on node.js and there's a problem locating node.js/npm for Windows which is causing the presubmit checks to fail.
,
Dec 6 2016
Sorry for taking a while - will have a fix soon. Meanwhile, you can run Closure compiler on devtools manually by going to: ~/chromium/src/third_party/WebKit/Source/devtools/scripts and running "python compile_frontend.py". Thanks.
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2178ba06208ff83c690514dc762f72c9842a150 commit e2178ba06208ff83c690514dc762f72c9842a150 Author: chenwilliam <chenwilliam@chromium.org> Date: Thu Dec 08 01:56:17 2016 DevTools: fix presubmit hooks for windows Note: For Windows, the presubmit hook works in cmd, however there's some issues in cygwin. BUG= 670058 Review-Url: https://codereview.chromium.org/2554573010 Cr-Commit-Position: refs/heads/master@{#437133} [modify] https://crrev.com/e2178ba06208ff83c690514dc762f72c9842a150/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/e2178ba06208ff83c690514dc762f72c9842a150/third_party/WebKit/Source/devtools/scripts/compile_frontend.py [modify] https://crrev.com/e2178ba06208ff83c690514dc762f72c9842a150/third_party/WebKit/Source/devtools/scripts/install_node_deps.py [modify] https://crrev.com/e2178ba06208ff83c690514dc762f72c9842a150/third_party/WebKit/Source/devtools/scripts/lint_javascript.py [add] https://crrev.com/e2178ba06208ff83c690514dc762f72c9842a150/third_party/WebKit/Source/devtools/scripts/utils.py
,
Dec 8 2016
elawrence@ - I landed a patch that fixes the presubmit hooks for Windows using cmd. There's still some issues left with cygwin so I'll leave this ticket open, but let me know if you still run into any issues.
,
Nov 13 2017
I left this open because of some cygwin issues, but it seems like there's few Chromium developers using cygwin so I'm closing this. |
||
►
Sign in to add a comment |
||
Comment 1 by elawrence@chromium.org
, Dec 6 2016