Not an RBS, but please add the test ASAP.

crrev.com/2403003002 is an optimization of existing functionality. This code is covered by numerous existing unit tests, which have helped me develop this feature.

May I ask what exactly you think is missing from the unit tests?


-------------

I'm not sure a regression test for the exact conditions in crbug.com/656959 would be particularly helpful, since the exact trigger for this exact bug requires that several factors to play together in particular ways [see below] and hence the test would likely be very fragile.


Trigger conditions were something like:
- A, instanceof test of a variable against a built-in object in JavaScript;
- surrounded by particular other bits of JS so that one half of the condition is true, the other isn't;
- called in a fashion where the tested object is the correct object but is accessed through a different context;
- called from 'hot' code so that it is optimized by Crankshaft.

vogelheim@, Thank you for the update. From the above comment: if this code is covered by numerous existing unit tests and preparing a regression test for the exact conditions in crbug.com/656959 wouldn't be helpful, then we are OK w/ not having new unit tests.

PS: Our intention is not to miss these regressions in case if there is a scope for adding reliable unit tests.

Thanks again!