New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670025 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----


Previous locations:
gerrit:5028


Sign in to add a comment

Submit button does not go through CQ

Project Member Reported by npm@chromium.org, Nov 30 2016

Issue description

I was expecting it to, since the Commit option on codereview.chromium.org goes through CQ before trying to commit. Wouldn't that be preferred, since that's what we want to do in most cases?
 
Cc: aga...@chromium.org
Labels: -Restrict-View-Google
Status: Accepted (was: New)
Can you provide a review URL? There is a plugin provided that adds CQ buttons, but since I don’t know what host you’re on, I can’t check.
Project: chromium
Moved issue gerrit:5028 to now be  issue chromium:670025 .
Components: Infra>Codereview>Gerrit
Labels: Pri-2
Owner: andyb...@chromium.org
Mergedinto: 667084
Status: Duplicate (was: Accepted)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ae7ed3d202f401d85e128f87a52c062b16f47093

commit ae7ed3d202f401d85e128f87a52c062b16f47093
Author: Shuqian Zhao <shuqianz@chromium.org>
Date: Fri Jan 06 20:55:21 2017

[autotest] temporarily disable verify hosts in testing push

BUG= chromium:670025 
TEST=None

Change-Id: I695e7e75edcfa0c4f4468082147b6e5a5020f544
Reviewed-on: https://chromium-review.googlesource.com/425859
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>
Commit-Queue: Shuqian Zhao <shuqianz@chromium.org>
Tested-by: Shuqian Zhao <shuqianz@chromium.org>

[modify] https://crrev.com/ae7ed3d202f401d85e128f87a52c062b16f47093/site_utils/test_push.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/83cfa5bcef8a668b973af00b6bcfd4ce1f0fe52a

commit 83cfa5bcef8a668b973af00b6bcfd4ce1f0fe52a
Author: Brian Norris <briannorris@chromium.org>
Date: Fri Jan 06 23:52:05 2017

test_push: fix BadIndentation

autotest-0.0.2-r7834: IndentationError: expected an indented block
autotest-0.0.2-r7834: Running autotest_lib.client.cros.crash.user_crash_test

BUG= chromium:670025 
TEST=trybots

Change-Id: I2cc886ba48a7e47899d8a9a93079b63ed51a48e3
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/425782

[modify] https://crrev.com/83cfa5bcef8a668b973af00b6bcfd4ce1f0fe52a/site_utils/test_push.py

Sign in to add a comment