New issue
Advanced search Search tips

Issue 670017 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Protobuf Library gni enforces lite version to deps

Project Member Reported by rhalavati@chromium.org, Nov 30 2016

Issue description

third_party/protobuf library's gni file enforces inclusion of protobuf lite library to any project that uses protobuf. This creates conflicts in projects that need to use the full version of this library. An input switch is needed to specify which version to include if it is needed.
 
Owner: rhalavati@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffa07a52a801ce805fd5f01f9984d4df2a71b620

commit ffa07a52a801ce805fd5f01f9984d4df2a71b620
Author: rhalavati <rhalavati@chromium.org>
Date: Wed Nov 30 20:59:31 2016

Update for proto_library.gni

An optional parameter is added to proto_library.gni that lets the user request adding full version to deps instead of lite version.

BUG= 670017 

Review-Url: https://codereview.chromium.org/2542563003
Cr-Commit-Position: refs/heads/master@{#435411}

[modify] https://crrev.com/ffa07a52a801ce805fd5f01f9984d4df2a71b620/third_party/protobuf/proto_library.gni

Status: Fixed (was: Assigned)

Sign in to add a comment