New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670012 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chromium cannot read and write to its Data Directory

Reported by debugz...@gmail.com, Nov 30 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2937.0 Safari/537.36

Steps to reproduce the problem:
1. Go to https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Win_x64/435311/
2. Download chrome-win32.zip
3. Unzip chrome-win32.zip
4. Execute in a Command Prompt: chrome.exe --user-data-dir="a b c"

What is the expected behavior?

What went wrong?
Chromium cannot read and write to its Data Directory

Did this work before? N/A 

Chrome version: 57.0.2937.0  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 24.0 r0
 
crbug.PNG
39.4 KB View Download
Components: Internals>Installer
Labels: -Pri-2 M-57 ReleaseBlock-Dev Pri-1
Owner: scottmg@chromium.org
Status: Assigned (was: Unconfirmed)
As per the above bisect, possible suspect.

https://chromium.googlesource.com/chromium/src/+/7433a2b305bbfcb8c469cddab9a1a3ab2c5b70d1

Assigning to Scott for updates.
Cc: ligim...@chromium.org
Components: -Internals>Installer
Labels: -Via-Wizard-Other
Status: Started (was: Assigned)
Thanks. Crappy command line parser in chrome_elf. :(
Cc: scottmg@chromium.org samu...@chromium.org
 Issue chromedriver:1619  has been merged into this issue.

Comment 6 by canb...@gmail.com, Dec 1 2016

-user-data-dir flag is ignored in canary. I guess this is same bug so i didnt file a new bug.
The occurs with a valid path
 --user-data-dir="c:/CanaryDev" --disable-web-security

This has always worked up until this morning.
Admin right does not change a thing.
in Chrome version 57.0.2935.0 Channel: canary
--user-data-dir="..\User Data" - works perfect!

but in 57.0.2937.0, 57.0.2938.0, 57.0.2938.1 - popup error:

---------------------------
Failed To Create Data Directory
---------------------------
Google Chrome cannot read and write to its data directory:

"..\User Data"
---------------------------
ОК   
---------------------------
Sorry. :( It'll work if you specify a path without spaces, and don't use quotes on the command line. A fix is on the way.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8882778ceb608911d96e7e485dbbff4db5c2b83

commit e8882778ceb608911d96e7e485dbbff4db5c2b83
Author: scottmg <scottmg@chromium.org>
Date: Fri Dec 02 22:28:09 2016

Handle spaces and quotes in chrome_elf command line parser

This is the worst sort of procedural stateful goopy code. I followed the
pseudo-code from
http://www.windowsinspired.com/how-a-windows-programs-splits-its-command-line-into-individual-arguments/
and verified against calling CommandLineToArgvW() which is what we're
attempting to emulate here.

Two tests were removed from
InstallStaticTest.GetSwitchValueFromCommandLineTest because I don't
believe they were correct (spaces after the equal sign), but maybe
Ananta can correct me on that.

R=grt@chromium.org
BUG= 670012 

Review-Url: https://codereview.chromium.org/2543503003
Cr-Commit-Position: refs/heads/master@{#436056}

[modify] https://crrev.com/e8882778ceb608911d96e7e485dbbff4db5c2b83/chrome/install_static/install_util.cc
[modify] https://crrev.com/e8882778ceb608911d96e7e485dbbff4db5c2b83/chrome/install_static/install_util.h
[modify] https://crrev.com/e8882778ceb608911d96e7e485dbbff4db5c2b83/chrome/install_static/install_util_unittest.cc

Status: Fixed (was: Started)
This should be fixed in tomorrow's Canary (I think it'll be called 57.0.2940.x, but not positive). Sorry for the breakage and delay.
Thanks for the fix, Scott !

Chromedriver windows bot is green again.
https://build.chromium.org/p/chromium.chromedriver/builders/Win7
in new Chrome version 57.0.2942.0 Channel: canary
relative paths - don't work...

in Chrome version 57.0.2935.0 Channel: canary
--user-data-dir="..\UserData" - perfectly worked!

can add or return this opportunity?
Dang. Never considered using a relative dir there as it seems scary. :) But yes, I'll take a look.
in newest Chrome versions  57.0.2944.0, 57.0.2946.0, 57.0.2948.0, 57.0.2949.0
relative paths - don't work...

can return this opportunity?
I just tested at head and 57.0.2953.2 and relative dirs seem to work. Could you be more specific about what's not working if you still have a problem?
Tell me how you've installed version Canaries 57.0.2953.2 ?
If you now upload the maximum version - 57.0.2953.0.
Maximum version 57.0.2953.0 - if now upload.
Oh, sorry, .2 is identical to .0, just built with a different compiler.
in Chrome version 57.0.2953.0 Canary
chrome.exe --user-data-dir="..\UserData" relative paths - don't work...

in Chrome version 57.0.2935.0 Channel: canary
--user-data-dir="..\UserData" - perfectly worked! (just checked)
I'm sorry, I still can't reproduce the failure.

C:\Users\scott\AppData\Local\Google\Chrome SxS\Application>dir
 Volume in drive C has no label.
 Volume Serial Number is 88D1-EBAA

 Directory of C:\Users\scott\AppData\Local\Google\Chrome SxS\Application

2016-12-16  09:14 AM    <DIR>          .
2016-12-16  09:14 AM    <DIR>          ..
2016-12-16  04:40 AM    <DIR>          57.0.2953.2
2016-12-15  11:44 PM         1,065,304 chrome.exe
2016-12-16  04:40 AM               422 chrome.VisualElementsManifest.xml
2016-12-01  05:37 PM            49,250 debug.log
2016-09-23  08:38 PM    <DIR>          Dictionaries
2016-12-16  09:14 AM    <DIR>          SetupMetrics
               3 File(s)      1,114,976 bytes
               5 Dir(s)  419,343,478,784 bytes free

C:\Users\scott\AppData\Local\Google\Chrome SxS\Application>chrome --user-data-dir="..\UserData"

C:\Users\scott\AppData\Local\Google\Chrome SxS\Application>dir ..\userdata
 Volume in drive C has no label.
 Volume Serial Number is 88D1-EBAA

 Directory of C:\Users\scott\AppData\Local\Google\Chrome SxS\userdata

2016-12-16  01:29 PM    <DIR>          .
2016-12-16  01:29 PM    <DIR>          ..
2016-12-16  01:29 PM    <DIR>          CertificateTransparency
2016-12-16  01:29 PM    <DIR>          Crashpad
2016-12-16  01:29 PM         1,048,576 CrashpadMetrics-active.pma
2016-12-16  01:30 PM    <DIR>          Default
2016-12-16  01:29 PM    <DIR>          EVWhitelist
2016-12-16  01:29 PM    <DIR>          FileTypePolicies
2016-12-16  01:29 PM                 0 First Run
2016-12-16  01:29 PM            49,174 Local State
2016-12-16  01:29 PM                 0 lockfile
2016-12-16  01:29 PM    <DIR>          OriginTrials
2016-12-16  01:29 PM    <DIR>          PepperFlash
2016-12-16  01:29 PM    <DIR>          pnacl
2016-12-16  01:29 PM             5,120 Safe Browsing Channel IDs
2016-12-16  01:29 PM                 0 Safe Browsing Channel IDs-journal
2016-12-16  01:29 PM             7,168 Safe Browsing Cookies
2016-12-16  01:29 PM                 0 Safe Browsing Cookies-journal
2016-12-16  01:29 PM    <DIR>          ShaderCache
2016-12-16  01:29 PM    <DIR>          Subresource Filter
2016-12-16  01:29 PM    <DIR>          SwReporter
2016-12-16  01:29 PM    <DIR>          WidevineCdm
               8 File(s)      1,110,038 bytes
              14 Dir(s)  419,350,253,568 bytes free
Thank you very much, everything works perfectly!

Comment 22 Deleted

Comment 23 Deleted

Comment 24 Deleted

Comment 25 Deleted

Can you abort creation of empty dir ?

with command line: C:\Users\scott\AppData\Local\Google\Chrome SxS\Application\chrome.exe --user-data-dir="UserData"
Use Directory of: C:\Users\scott\AppData\Local\Google\Chrome SxS\Application\UserData
And create empty dir, which not used: C:\Users\scott\AppData\Local\Google\Chrome SxS\Application\58.0.3007.0\UserData

need fix: NOT NEED create empty dir: C:\Users\scott\AppData\Local\Google\Chrome SxS\Application\58.0.3007.0\UserData

with command line: C:\Users\scott\AppData\Local\Google\Chrome SxS\Application\chrome.exe --user-data-dir="..\Application\UserData"
Use Directory of: C:\Users\scott\AppData\Local\Google\Chrome SxS\Application\UserData
then create empty dir: C:\Users\scott\AppData\Local\Google\Chrome SxS\Application\Application\UserData

need fix: NOT NEED create empty dir, which not used: C:\Users\scott\AppData\Local\Google\Chrome SxS\Application\Application\UserData

Sign in to add a comment