New issue
Advanced search Search tips

Issue 670009 link

Starred by 1 user
Status: Fixed
Owner:
sahel@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Can long press and fling in same gesture on Android

Project Member Reported by tdres...@chromium.org, Nov 30 2016 
To repro:
- Open test.com
- Long press on a link, but just before the long press fires, fling.

It's a bit tricky, but you can fling and long press in the same gesture.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad908bef2e858b5786328b11b7b83f9a1d74fbb7

commit ad908bef2e858b5786328b11b7b83f9a1d74fbb7
Author: Sahel Sharify <sahel@chromium.org>
Date: Mon Aug 14 19:57:02 2017

Scroll/Fling cannot happen after long press.

Once long press event is sent, no scroll or fling event must be sent for
the rest of the event sequence.

Bug:  670009 
Test: GestureProviderTest.GestureLongPressPreventsScrolling
Change-Id: I39f54318cf3fdd2c583df277fb5d2e744730a35e
Reviewed-on: https://chromium-review.googlesource.com/613700
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494147}
[modify] https://crrev.com/ad908bef2e858b5786328b11b7b83f9a1d74fbb7/ui/events/gesture_detection/gesture_provider.cc
[modify] https://crrev.com/ad908bef2e858b5786328b11b7b83f9a1d74fbb7/ui/events/gesture_detection/gesture_provider_unittest.cc

Comment 2 by sahel@chromium.org, Aug 15 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48d76dc81628ffda0c4c56ac06e2dcbdecb57034

commit 48d76dc81628ffda0c4c56ac06e2dcbdecb57034
Author: Sahel Sharify <sahel@chromium.org>
Date: Wed Aug 16 17:57:44 2017

Revert "Scroll/Fling cannot happen after long press."

This reverts commit ad908bef2e858b5786328b11b7b83f9a1d74fbb7.

Preventing scrolling once long press is fired, breaks drag and drop.

TBR: tdresser@chromium.org
Bug:  755937 ,  670009 
Change-Id: Ib9f31e22e4494401fbebedb9974595fdfedae41c
Reviewed-on: https://chromium-review.googlesource.com/617063
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494853}
[modify] https://crrev.com/48d76dc81628ffda0c4c56ac06e2dcbdecb57034/ui/events/gesture_detection/gesture_provider.cc
[modify] https://crrev.com/48d76dc81628ffda0c4c56ac06e2dcbdecb57034/ui/events/gesture_detection/gesture_provider_unittest.cc
►

Sign in to add a comment