New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670008 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: ----
Type: ----



Sign in to add a comment

interactive_ui_tests failing on chromium.mac/Mac10.10 Tests

Project Member Reported by iclell...@chromium.org, Nov 30 2016

Issue description

interactive_ui_tests failing on chromium.mac/Mac10.10 Tests

Type: build-failure

Builders failed on: 
- Mac10.10 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests


WebViewFocusInteractiveTest.FocusAndVisibility is flaky on MacOS (See flake dashboard here: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests&tests=FocusAndVisibility)

Recent failure:
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/9988

The comment in the test "Send several tab-keys. The button inside webview should receive focus at least once." makes me think that the test is inherently flaky, but I'm disabling it for now on MacOS builders.
 
Labels: -Sheriff-Chromium
Owner: ekaramad@chromium.org
Assigning tentatively and removing from sheriff queue.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0e3d231b36e9ac9bbb19b79e15173ce1c6ce9db

commit d0e3d231b36e9ac9bbb19b79e15173ce1c6ce9db
Author: iclelland <iclelland@chromium.org>
Date: Wed Nov 30 20:20:20 2016

Disable flaky WebViewFocusInteractiveTest.FocusAndVisibility test on MacOS

BUG= 670008 
TBR=EhsanK

Review-Url: https://codereview.chromium.org/2542563004
Cr-Commit-Position: refs/heads/master@{#435396}

[modify] https://crrev.com/d0e3d231b36e9ac9bbb19b79e15173ce1c6ce9db/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Owner: aval...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f34dd22518c310f8b94bc75f4b82292f055a5f6c

commit f34dd22518c310f8b94bc75f4b82292f055a5f6c
Author: avallee <avallee@chromium.org>
Date: Wed Jan 25 21:52:37 2017

<webview>: Synchronize WebViewFocusInteractiveTest.FocusAndVisibility

Fix flakiness present on mac and re-enable the test for mac.

The guest js was drastically simplified to emit only two events to the guest,
button was focused and keyup.

The embedder then keeps the test in sync with each keypress and then
asserts that the guest button was focused or not.

There is a difference between oopif and browser plugin webviews that the
embedder in browserplugin might see all keyboard events and must
suppress those meant for the guest and only reply once the guest has
processed the keyboard input.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG= 670008 , 610819 

Review-Url: https://codereview.chromium.org/2648263006
Cr-Commit-Position: refs/heads/master@{#446130}

[modify] https://crrev.com/f34dd22518c310f8b94bc75f4b82292f055a5f6c/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/f34dd22518c310f8b94bc75f4b82292f055a5f6c/chrome/test/data/extensions/platform_apps/web_view/focus_visibility/guest.js
[modify] https://crrev.com/f34dd22518c310f8b94bc75f4b82292f055a5f6c/chrome/test/data/extensions/platform_apps/web_view/focus_visibility/window.html
[modify] https://crrev.com/f34dd22518c310f8b94bc75f4b82292f055a5f6c/chrome/test/data/extensions/platform_apps/web_view/focus_visibility/window.js

Status: Fixed (was: Started)

Sign in to add a comment