[Host] Add version information to host log for each client connection |
|
Issue descriptionOne of the problems I have found when scanning Windows ETW host logs is that the host version is not available unless the logging was started before the host was started (which is not usually the case). I'd like to include the host version when logging a connection to reduce the time needed for tracking down problems.
,
Nov 30 2016
There may be a way with ETW, but I'd have to experiment a bit. When you register an ETW provider, you can provide a callback which is used to tell you whether logging is enabled/disabled as well as the current level. This code is in a low-level Chromium class though so we may not have access to it. If we can register a second instance of the same provider GUID, then printing out debug info could work. The other option that might be useful is to just output to a log file in TEMP like linux does.
,
Nov 30 2016
I'm not sure it's worth changing how we do logging just so that we can get the host version in more situations than when a connection is received, but if there are other benefits, then it might be worth investigating. Enabling ETW is rather advanced for a typical user, so logging to a file might make more it easier. The downsides are potentially using up a lot of disk space. Overall, I think your original suggestion is probably a good compromise. |
|
►
Sign in to add a comment |
|
Comment 1 by jamiewa...@chromium.org
, Nov 30 2016