New issue
Advanced search Search tips

Issue 670003 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Omnibox - HistoryQuick Provider - When Splitting on Cursor, Don't Run Duplicate Searches

Project Member Reported by mpear...@chromium.org, Nov 30 2016

Issue description


Split from  bug 669727 .

Currently, if the user has the cursor in the middle of a string and makes an edit, triggering a new fetching of omnibox suggestions, we allow the user's text to split at the cursor.  In other words, we take the position of the cursor as interesting and try searching for both the text in the omnibox and the text in the omnibox as if there was a space character at the cursor.

This can result in unnecessary work if there is already a space character adjacent to the cursor.

That said, I *think* the caching done in url_index_private_data probably means these redundant calls take little to no time (because all the search terms are the same and so one pass should have lots of cache hits).

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d8bbddd8416f906955738a2f70cb402527d079c

commit 7d8bbddd8416f906955738a2f70cb402527d079c
Author: mpearson <mpearson@chromium.org>
Date: Tue May 09 06:00:17 2017

Omnibox - HistoryQuick Provider - Don't Run Duplicate Searches

(when splitting on cursor)

If the cursor is next to a space, there's no need to insert a space
where the cursor is.

Not tested.  Please give this change a thorough review.

BUG= 670003 

Review-Url: https://codereview.chromium.org/2842513006
Cr-Commit-Position: refs/heads/master@{#470242}

[modify] https://crrev.com/7d8bbddd8416f906955738a2f70cb402527d079c/components/omnibox/browser/url_index_private_data.cc

Status: Fixed (was: Started)

Sign in to add a comment