New issue
Advanced search Search tips

Issue 670001 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove Redundant Field Initialization from Chrome Codebase

Project Member Reported by agrieve@chromium.org, Nov 30 2016

Issue description

Feature request for an Android Lint check here:
https://code.google.com/p/android/issues/detail?id=226486

We should do a one-time removal of them using Android Studio:
- Open up the inspections UI and search for "Redundant Field Initialization"
 
Cc: agrieve@chromium.org
CL is here: https://codereview.chromium.org/2548013002/. Should I submit it now or wait until the lint check is complete?
I'd just go for it. I suspect the wins are small enough that it'd be fine if we just ran it every couple of years :P.

I'd be curious to see what the savings are though. e.g. build before & after with is_java_debug=false and compare uncompressed classes.dex size.
I would like to know the savings too = we often encourage explicit initialization for readability benefits (esp. when the team mostly writes C++ - having everything uninitialized in Java doesn't look right and requires extra effort to keep the defaults in mind sometimes) so I personally would object the change unless the wins outweigh the costs.
Size of ChromePublic.apk uncompressed classes.dex:

w/out patch: 5843180 bytes
with patch:  5835560 bytes

Savings of:     7620 bytes



7kb seems worth it to me. This is also 7kb of code run at class load time that is no longer needing to run.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b97db470c6419fe4f15daf091789bba251ec437

commit 2b97db470c6419fe4f15daf091789bba251ec437
Author: estevenson <estevenson@chromium.org>
Date: Tue Dec 13 17:50:21 2016

Remove redundant field initialization in Java code.

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This CL shrinks the uncompressed
size of classes.dex by 8.6 kb for proguarded chrome_public_apk.

Change was made with Android Studio (Analyze > Run inspection by name >
Redundant field initialization), and fixes all instances in projects
currently generated by build/android/gradle/generate_gradle.py.

NOPRESUBMIT=true

BUG= 670001 

Review-Url: https://codereview.chromium.org/2548013002
Cr-Commit-Position: refs/heads/master@{#438216}

[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/java/src/org/chromium/android_webview/AwContentsLifecycleNotifier.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/java/src/org/chromium/android_webview/AwDevToolsServer.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/java/src/org/chromium/android_webview/AwServiceWorkerSettings.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/java/src/org/chromium/android_webview/AwSettings.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnFormResubmissionTest.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/javatests/src/org/chromium/android_webview/test/AwPermissionManagerTest.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageStartedTest.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedHttpErrorTest.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/android/java/src/org/chromium/base/NonThreadSafe.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/android/java/src/org/chromium/base/ObserverList.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/android/java/src/org/chromium/base/PerfTraceEvent.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/android/java/src/org/chromium/base/SystemMessageHandler.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/android/java/src/org/chromium/base/ThreadUtils.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/android/java/src/org/chromium/base/TraceEvent.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/android/java/src/org/chromium/base/library_loader/LegacyLinker.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/android/java/src/org/chromium/base/library_loader/Linker.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/android/java/src/org/chromium/base/library_loader/ModernLinker.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/android/java/src/org/chromium/base/metrics/RecordHistogram.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/android/java/src/org/chromium/base/metrics/RecordUserAction.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/base/test/android/javatests/src/org/chromium/base/test/util/ScalableTimeout.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/ChromeStrictMode.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/DevToolsServer.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/accessibility/FontSizePrefs.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillLogger.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListViewAdapter.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchImageControl.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/CascadeEventFilter.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/EdgeSwipeEventFilter.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/EventFilter.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/eventfilter/GestureEventFilter.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackTab.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadRetry.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/customtabs/RequestThrottler.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/customtabs/SeparateTaskManagedCustomTabActivity.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/gcore/GoogleApiClientHelper.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/invalidation/ChromeBrowserSyncAdapterService.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteController.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaRouteChooserDialogFactory.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteChooserDialogManager.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteControllerDialogManager.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMessageHandler.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionInfo.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/ClientRecord.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebappUma.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsExpandableListView.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressIndicatorView.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaClient.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxPrerender.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/partnerbookmarks/PartnerBookmarksReader.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/partnercustomizations/PartnerBrowserCustomizations.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebEnvironment.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheLauncher.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninConfirmationView.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/signin/OAuth2TokenService.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProvider.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/tab/TabUma.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ActionModeController.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/util/AccessibilityUtil.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappAuthenticator.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/widget/SlowedProgressBar.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/widget/VerticallyFixedEditText.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindResultBar.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FakeServerHelper.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/GmsCoreSyncListenerTest.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationData.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationTestUtils.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeSigninUtils.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/MockTabModelSelector.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GoogleCloudMessagingV2.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/components/gcm_driver/instance_id/android/java/src/org/chromium/components/gcm_driver/instance_id/InstanceIDBridge.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/components/gcm_driver/instance_id/android/java/src/org/chromium/components/gcm_driver/instance_id/InstanceIDWithSubtype.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/components/gcm_driver/instance_id/android/javatests/src/org/chromium/components/gcm_driver/instance_id/FakeInstanceIDWithSubtype.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/components/invalidation/impl/android/javatests/src/org/chromium/components/invalidation/TestableInvalidationClientService.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/components/policy/android/java/src/org/chromium/policy/AbstractAppRestrictionsProvider.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/components/policy/android/java/src/org/chromium/policy/CombinedPolicyProvider.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/components/precache/android/java/src/org/chromium/components/precache/DeviceState.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/components/safe_json/android/java/src/org/chromium/components/safejson/JsonSanitizer.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/components/sync/android/java/src/org/chromium/components/sync/AndroidSyncSettings.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/components/sync/android/java/src/org/chromium/components/sync/ModelTypeHelper.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/content/public/android/java/src/org/chromium/content/browser/AudioFocusDelegate.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java
[modify] https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437/content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java
[modify] https://crrev.com/2b97db470c6419fe4f
Status: Fixed (was: Assigned)

Sign in to add a comment