New issue
Advanced search Search tips

Issue 669994 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
vadimsh@chromium.org
estaab@chromium.org
hinoka@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Support signed Google Storage URL generation and direct loading fast-path in LogDog CLI client.

Project Member Reported by d...@chromium.org, Nov 30 2016 
Since logs are stored in Google Storage, we can greatly speed up retrieval of archived logs by allowing the LogDog client to directly access the Google Storage record. In order to do this, we need to:
1) Allow the Coordinator to supply a signed URL if requested.
2) Configure the client to load logs from the signed URL if available.

Since servicing the Get request is predicated on the user actually having access to the log stream, it is safe to inline this with the other Get request logic.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/2568e271f92ed046ea2c10318e90c2f53147eda1

commit 2568e271f92ed046ea2c10318e90c2f53147eda1
Author: dnj <dnj@chromium.org>
Date: Thu Dec 01 18:03:49 2016

LogDog: Add signed GS URL fetching.

Allow a "Get" RPC request to additionally request a signed URL to the
archive log entry stream, if available.

To really support this, we restructure (for the better) the internal
service API and the Coordinator test framework to enable fetching bound
storage instances instead of the motley assortment of composite services
that was previously implemented.

BUG= chromium:669994 
TEST=unit

Review-Url: https://codereview.chromium.org/2538203002

[modify] https://crrev.com/2568e271f92ed046ea2c10318e90c2f53147eda1/logdog/api/endpoints/coordinator/logs/v1/logs.pb.go
[modify] https://crrev.com/2568e271f92ed046ea2c10318e90c2f53147eda1/logdog/api/endpoints/coordinator/logs/v1/logs.proto
[modify] https://crrev.com/2568e271f92ed046ea2c10318e90c2f53147eda1/logdog/api/endpoints/coordinator/logs/v1/pb.discovery.go
[modify] https://crrev.com/2568e271f92ed046ea2c10318e90c2f53147eda1/logdog/appengine/coordinator/coordinatorTest/context.go
[modify] https://crrev.com/2568e271f92ed046ea2c10318e90c2f53147eda1/logdog/appengine/coordinator/coordinatorTest/service.go
[add] https://crrev.com/2568e271f92ed046ea2c10318e90c2f53147eda1/logdog/appengine/coordinator/coordinatorTest/storage.go
[delete] https://crrev.com/982d8b5f9e60122df55521188b9f884c615fd5e9/logdog/appengine/coordinator/coordinatorTest/storage_cache.go
[modify] https://crrev.com/2568e271f92ed046ea2c10318e90c2f53147eda1/logdog/appengine/coordinator/endpoints/logs/get.go
[modify] https://crrev.com/2568e271f92ed046ea2c10318e90c2f53147eda1/logdog/appengine/coordinator/endpoints/logs/get_test.go
[modify] https://crrev.com/2568e271f92ed046ea2c10318e90c2f53147eda1/logdog/appengine/coordinator/service.go
[modify] https://crrev.com/2568e271f92ed046ea2c10318e90c2f53147eda1/logdog/common/storage/archive/logdog_archive_test/main.go
[modify] https://crrev.com/2568e271f92ed046ea2c10318e90c2f53147eda1/logdog/common/storage/archive/storage.go
[modify] https://crrev.com/2568e271f92ed046ea2c10318e90c2f53147eda1/logdog/common/storage/archive/storage_test.go

Comment 2 by estaab@chromium.org, Mar 7 2017

Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 8 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by estaab@chromium.org, Mar 8 2018

Status: Fixed (was: Untriaged)
I'm not sure if this is fixed after that CL but from the description I think it is.
►

Sign in to add a comment