Issue 669983 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	koten...@yandex-team.ru
Closed:	Dec 2016
Components:	UI>Browser>FindInPage
EstimatedDays:	----
NextAction:	----
OS:	Mac
Pri:	3
Type:	Bug

Empty in-page search results on the page containing the search pattern

Project Member Reported by koten...@yandex-team.ru, Nov 30 2016

Issue description

Version: 57.0.2931.0
OS: Mac, maybe others

What steps will reproduce the problem?
(1) Navigate to google.com
(2) In-page search "cat", there should be no matches.
(3) Type "cat" into the search box, hit enter.
(4) Open in-page search again, hit enter.

What is the expected result?
Multiple "cat"s found.

What happens instead?
Zero "cat"s found, but the page will scroll to the first result.

Comment 1 by koten...@yandex-team.ru, Nov 30 2016

The word is actually found, but nothing is highlighted. Another way to reproduce it is to add text containing the search pattern via Javascript.
The problem is that TextFinder::shouldScopeMatches() returns false for the same text if the previous scoping found nothing, which is controlled by m_lastFindRequestCompletedWithNoMatches.
I will address this problem, but first I'll introduce a small refactoring of the scoping process.

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b943a912b47fa31360024c78ab996f12705812a9

commit b943a912b47fa31360024c78ab996f12705812a9
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Fri Dec 02 10:11:16 2016

Refactor TextFinder::scopeStringMatches().

Extract startScopingStringMatches() function.
Use single Member<DeferredScopeStringMatches> instead of a vector.

BUG= 669983 

Review-Url: https://codereview.chromium.org/2546513002
Cr-Commit-Position: refs/heads/master@{#435906}

[modify] https://crrev.com/b943a912b47fa31360024c78ab996f12705812a9/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/b943a912b47fa31360024c78ab996f12705812a9/third_party/WebKit/Source/web/TextFinder.h
[modify] https://crrev.com/b943a912b47fa31360024c78ab996f12705812a9/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/b943a912b47fa31360024c78ab996f12705812a9/third_party/WebKit/Source/web/tests/TextFinderTest.cpp
[modify] https://crrev.com/b943a912b47fa31360024c78ab996f12705812a9/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Comment 3 by dglazkov@chromium.org, Dec 3 2016

Components: -Blink UI>Browser>FindInPage
Status: Started (was: Untriaged)

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f875cc4451fc999c357d381d9fdd165c0a86527

commit 7f875cc4451fc999c357d381d9fdd165c0a86527
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Mon Dec 05 01:46:32 2016

Fix search restart after zero entries.

BUG= 669983 

Review-Url: https://codereview.chromium.org/2537773008
Cr-Commit-Position: refs/heads/master@{#436215}

[modify] https://crrev.com/7f875cc4451fc999c357d381d9fdd165c0a86527/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/7f875cc4451fc999c357d381d9fdd165c0a86527/third_party/WebKit/Source/web/tests/TextFinderTest.cpp

Comment 5 by koten...@yandex-team.ru, Dec 5 2016

Status: Fixed (was: Started)

►

Issue 669983 link

Issue metadata

Empty in-page search results on the page containing the search pattern

Issue description

Comment 1 by koten...@yandex-team.ru, Nov 30 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Dec 2 2016

Comment 2 Deleted

Comment 3 by dglazkov@chromium.org, Dec 3 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Dec 5 2016

Comment 4 Deleted

Comment 5 by koten...@yandex-team.ru, Dec 5 2016

Comment 5 Deleted

Sign in to add a comment