New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 669961 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GN "android_apk" rule does not support generated proguard config files

Project Member Reported by kapishnikov@chromium.org, Nov 30 2016

Issue description

When a proguard config file is generated by some other target and referenced in proguard_config of an android_apk rule, an error similar to this one may appear.

ERROR Input to targets not generated by a dependency.
The file:
  //out/Debug/cronet/proguard_native.cfg
is listed as an input or source for the targets:
  //components/cronet/android:cronet_sample_apk__proguard
but this file was not generated by any dependencies of the targets. The target
that generates the file is:
  //components/cronet/android:cronet_combine_proguard_flags

This happens because the generated __proguard rule doesn't forward "deps" variable from the android_apk.
 
Uploaded a CL with a proposed fix: https://codereview.chromium.org/2541763003/
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6130422db2a8ff2a08ab0cd2b19d861825c900ae

commit 6130422db2a8ff2a08ab0cd2b19d861825c900ae
Author: kapishnikov <kapishnikov@chromium.org>
Date: Wed Nov 30 22:54:59 2016

[GN] Add support for generated proguard configs in android_apk

BUG= 669961 

Review-Url: https://codereview.chromium.org/2541763003
Cr-Commit-Position: refs/heads/master@{#435460}

[modify] https://crrev.com/6130422db2a8ff2a08ab0cd2b19d861825c900ae/build/config/android/rules.gni

Status: Fixed (was: Started)

Sign in to add a comment