New issue
Advanced search Search tips

Issue 669956 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Create new Chrome-Proxy Integration Test Framework

Project Member Reported by robertogden@chromium.org, Nov 30 2016

Issue description

Telemetry isn't going to work for us much longer going forward. Create our own test framework.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90653cee40f4651debda27fc33f34bac224fd473

commit 90653cee40f4651debda27fc33f34bac224fd473
Author: robertogden <robertogden@chromium.org>
Date: Thu Dec 01 00:45:20 2016

Remove TODO for smart page.
Doesn't actually add any features, breaks things down the line.

BUG= 669956 

Review-Url: https://codereview.chromium.org/2534243003
Cr-Commit-Position: refs/heads/master@{#435502}

[modify] https://crrev.com/90653cee40f4651debda27fc33f34bac224fd473/tools/chrome_proxy/webdriver/common.py

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec1ab21b1df2c867a746ab50261ea02aad4256bc

commit ec1ab21b1df2c867a746ab50261ea02aad4256bc
Author: robertogden <robertogden@chromium.org>
Date: Thu Dec 01 01:53:21 2016

Fix cmd line args override in common.py

In certain cases, it is important to be able to specify different command line arguments to chrome at the time the test is being run rather than what is in code. For example, running against a different proxy than is in the code.
This CL turns on the handling for this functionality and fixes a few bugs with it.

BUG= 669956 

Review-Url: https://codereview.chromium.org/2538773004
Cr-Commit-Position: refs/heads/master@{#435525}

[modify] https://crrev.com/ec1ab21b1df2c867a746ab50261ea02aad4256bc/tools/chrome_proxy/webdriver/common.py

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6094294f686de52b1f7afc8daf18f23b21e5f51f

commit 6094294f686de52b1f7afc8daf18f23b21e5f51f
Author: robertogden <robertogden@chromium.org>
Date: Wed Dec 07 00:48:31 2016

Add functionality for Android.

Tests can be run on Android simply by passing the --android flag with a device connected on adb.
Removes usage of chrome_options. This object is parsed into capabilities in ChromeDriver anyways. This gives us more control over Chrome startup.

BUG= 669956 

Review-Url: https://codereview.chromium.org/2555833003
Cr-Commit-Position: refs/heads/master@{#436793}

[modify] https://crrev.com/6094294f686de52b1f7afc8daf18f23b21e5f51f/tools/chrome_proxy/webdriver/common.py

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7ab51d397138f491c0eeaa6ad50f320b1dcbfc4

commit c7ab51d397138f491c0eeaa6ad50f320b1dcbfc4
Author: robertogden <robertogden@chromium.org>
Date: Wed Dec 07 19:06:02 2016

Add timeouts to LoadPage and ExecJavascipt.

ExecJavascriptStatement function also added to clarify how javascript is
run with Chromedriver.

BUG= 669956 

Review-Url: https://codereview.chromium.org/2554383002
Cr-Commit-Position: refs/heads/master@{#437025}

[modify] https://crrev.com/c7ab51d397138f491c0eeaa6ad50f320b1dcbfc4/tools/chrome_proxy/webdriver/common.py
[modify] https://crrev.com/c7ab51d397138f491c0eeaa6ad50f320b1dcbfc4/tools/chrome_proxy/webdriver/simple_smoke.py

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db5af7f8157fd8cfc627d54cc29dbad4ebea4a6f

commit db5af7f8157fd8cfc627d54cc29dbad4ebea4a6f
Author: robertogden <robertogden@chromium.org>
Date: Tue Dec 13 23:04:12 2016

Add protocol and port to HTTPResponse.

Also hardens MakeHTTPResponse()

BUG= 669956 

Review-Url: https://codereview.chromium.org/2571003002
Cr-Commit-Position: refs/heads/master@{#438324}

[modify] https://crrev.com/db5af7f8157fd8cfc627d54cc29dbad4ebea4a6f/tools/chrome_proxy/webdriver/common.py
[modify] https://crrev.com/db5af7f8157fd8cfc627d54cc29dbad4ebea4a6f/tools/chrome_proxy/webdriver/simple_smoke.py

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3462ad04053cb5241140fb7f806c6f382f179a05

commit 3462ad04053cb5241140fb7f806c6f382f179a05
Author: robertogden <robertogden@chromium.org>
Date: Wed Dec 14 03:16:53 2016

Add common IntegrationTest class with assertions and RunAllTests() func

Also cleans up command line args and HTTPResponse header processing.

R=sclittle
BUG= 669956 

Review-Url: https://codereview.chromium.org/2574923002
Cr-Commit-Position: refs/heads/master@{#438410}

[modify] https://crrev.com/3462ad04053cb5241140fb7f806c6f382f179a05/tools/chrome_proxy/webdriver/common.py
[modify] https://crrev.com/3462ad04053cb5241140fb7f806c6f382f179a05/tools/chrome_proxy/webdriver/simple_smoke.py

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb07db2852eb2de9f625d0f0365f9683ba9a90ba

commit bb07db2852eb2de9f625d0f0365f9683ba9a90ba
Author: robertogden <robertogden@chromium.org>
Date: Thu Dec 15 16:54:18 2016

Add logging to TestDriver

BUG= 669956 

Review-Url: https://codereview.chromium.org/2578713002
Cr-Commit-Position: refs/heads/master@{#438849}

[modify] https://crrev.com/bb07db2852eb2de9f625d0f0365f9683ba9a90ba/tools/chrome_proxy/webdriver/common.py

Status: Verified (was: Assigned)
With that, the new test framework is feature complete!
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85e300db3062e709af455204125e42cce550f1c7

commit 85e300db3062e709af455204125e42cce550f1c7
Author: robertogden <robertogden@chromium.org>
Date: Mon Dec 19 23:17:49 2016

Add domain checking to returned HTTPResponses

I discovered today that Chrome will occasionally include a page loaded
at startup with a url like 'data:,' or 'about:blank'. This code will
remove those responses by default and shouldn't affect standard testing
use cases.

BUG= 669956 
R=sclittle

Review-Url: https://codereview.chromium.org/2572383003
Cr-Commit-Position: refs/heads/master@{#439608}

[modify] https://crrev.com/85e300db3062e709af455204125e42cce550f1c7/tools/chrome_proxy/webdriver/common.py

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b14ad5a6b380c208012bc21e5899669fca9a3eae

commit b14ad5a6b380c208012bc21e5899669fca9a3eae
Author: robertogden <robertogden@chromium.org>
Date: Thu Dec 22 20:05:55 2016

Create run_all_tests script.

Adds a simple script to run all tests. Refactors the
IntegrationTest.RunAllTests() method to be generic.

BUG= 669956 

Review-Url: https://codereview.chromium.org/2598053002
Cr-Commit-Position: refs/heads/master@{#440482}

[modify] https://crrev.com/b14ad5a6b380c208012bc21e5899669fca9a3eae/tools/chrome_proxy/webdriver/common.py
[add] https://crrev.com/b14ad5a6b380c208012bc21e5899669fca9a3eae/tools/chrome_proxy/webdriver/run_all_tests.py

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2afc205491aaace614ef521ce636fc59d0a83e8b

commit 2afc205491aaace614ef521ce636fc59d0a83e8b
Author: robertogden <robertogden@chromium.org>
Date: Wed Jan 11 22:09:49 2017

Add --test_filter with * wildcard functionality for classname and
methodname.

Example:
  --test_filter=Hello.W*
  Matches classname='Hello' and methodname='W*'

BUG= 669956 

Review-Url: https://codereview.chromium.org/2624133003
Cr-Commit-Position: refs/heads/master@{#443004}

[modify] https://crrev.com/2afc205491aaace614ef521ce636fc59d0a83e8b/tools/chrome_proxy/webdriver/common.py

Sign in to add a comment