New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 669939 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Dec 2017
Cc:
█ alexclarke@chromium.org
pfeldman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add a parameter to DOM.getNodeForLocation to skip shadow nodes

Project Member Reported by joaodasilva@chromium.org, Nov 30 2016 
Verified on Linux 56.0.2924.3 unstable.

DOM.getNodeForLocation returns a shadow node when the location hits inside an <input type="text"> or <textarea> element.

It would be useful to have a param to skip shadow nodes and get the non-shadow ancestor that includes that node instead.

Comment 1 by pfeldman@chromium.org, Nov 30 2016

Labels: Hotlist-GoodFirstBug
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d66ff70d9c4f98de29ec8bdb8e939241599106ea

commit d66ff70d9c4f98de29ec8bdb8e939241599106ea
Author: peleg3 <peleg3@gmail.com>
Date: Thu Mar 23 22:38:35 2017

Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor

Added optional param, includeUserAgentShadowDOM, to allow
DOM.getNodeForLocation to skip to the nearest non-shadow ancestor.

BUG= 669939 
TEST=Run blink test with: python third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-skip-shadow.html

Review-Url: https://codereview.chromium.org/2763913002
Cr-Commit-Position: refs/heads/master@{#459261}

[add] https://crrev.com/d66ff70d9c4f98de29ec8bdb8e939241599106ea/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-skip-shadow-expected.txt
[add] https://crrev.com/d66ff70d9c4f98de29ec8bdb8e939241599106ea/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-skip-shadow.html
[modify] https://crrev.com/d66ff70d9c4f98de29ec8bdb8e939241599106ea/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/d66ff70d9c4f98de29ec8bdb8e939241599106ea/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
[modify] https://crrev.com/d66ff70d9c4f98de29ec8bdb8e939241599106ea/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/d66ff70d9c4f98de29ec8bdb8e939241599106ea/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
[modify] https://crrev.com/d66ff70d9c4f98de29ec8bdb8e939241599106ea/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

Comment 3 by pfeldman@chromium.org, Dec 11 2017

Status: Fixed (was: Available)
►

Sign in to add a comment