New issue
Advanced search Search tips

Issue 669936 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression

Blocking:
issue 654917



Sign in to add a comment

Touch handler broken in ToT Chrome [Linux]

Project Member Reported by wjmaclean@chromium.org, Nov 30 2016

Issue description

Version: refs/heads/master@{#435095}
OS: Linux (but I haven't tested on others yet ...)

What steps will reproduce the problem?
(1) open http://rbyers.github.io/paint.html
(2) touch the screen

What is the expected result?

Traces of the finger's path should be drawn.

What happens instead?

Nothing.

*** or ***

 (1) open chrome://chrome-signin/?source=0
 (2) try clicking links (nothing happens)

What is the expected result?

Navigation to the linked page.

What happens instead?

Nothing.

Please use labels and text to provide additional information.

 
Labels: Hotlist-Input-Dev
Owner: mustaq@chromium.org
Status: Assigned (was: Untriaged)
I can sort of reproduce this. It happens sometimes when I refresh devtools. Wonder if it is caused by  https://codereview.chromium.org/2467913002

Blocking: 654917
This bug is a blocker for fixing page-scale propagation for OOPIF, which is in itself a blocker for TDI
I couldn't repro using touch emulation in devtools. James, did you use a touch-screen or used devtools emulation?
Touch emulation at present is rather broken, you'll need a real touchscreen.

Perhaps try a ToT build on a Pixel (though I haven't checked myself to see if this repros on CrOS).

Comment 5 by mcnee@chromium.org, Dec 1 2016

I just tried this on a Pixel. Could not reproduce.
Same for me, couldn't repro in Pixel ToT with all chrome://flags at default values.

Wondering if touch-event flag is disabled in James case.
I'll double check that later tonight when I'm back in the office. Would touch stuff work on pages without touch-handlers if the flag is not on? I'm testing with a profile that, before I sync'd my repro yesterday, worked ok. So I'm assuming the profile had that on, but I'll verify in any case.
Yeah, we landed last week a touch-flag change (crrev.com/2467913002) that missed the web-compat implications for part of the change. We are working on a fix (crrev.com/2531413002) now.

Until we land the second CL, set the touch flag to enable or disable (not auto) and see if that works for you.
Sure, I'll give that a try tonight, and update the bug.
Yeah, that was it. I'm assuming the flag was enabled before, but now it was showing 'disabled' in about:flags. Weird, cause I'm assuming it wasn't disabled before, otherwise the events would have failed prior to my repo sync too.
Cc: sunyunjia@chromium.org
Hmm, if the flag switched from "enabled" to "disabled" automatically, I suspect chrome profile might have messed up the stored flag state even though we didn't modify any exposed string!

Anyway, the fix (crrev.com/2531413002/ ) landed last night. You can safely to back to "auto" after it. Let us know if you still see any problem.

Status: Fixed (was: Assigned)

Sign in to add a comment