New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 669918 link

Starred by 1 user
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
eroman@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Standardize "net" category trace events

Project Member Reported by xunji...@chromium.org, Nov 30 2016 
Some "net" trace events are logged with "disabled-by-default-" prefix and some are not.


e.g.
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("net"),                   "NetworkDelegate::NotifyStartTransaction");

vs

TRACE_EVENT0("net", "SocketPosix::OnFileCanReadWithoutBlocking");

We should convert them to all using "disabled-by-default-" prefix.

Comment 1 by mmenke@chromium.org, Nov 30 2016 

Should we have a constant kNetTracingCategory?

Comment 2 by xunji...@chromium.org, Nov 30 2016 

I was thinking the same thing. But I am not sure where to put this constant? Should we create a file in src/net/log/ to put this constant?
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f

commit 0b7f5b65efc8cfd59c04619e92a052dc2a0a965f
Author: xunjieli <xunjieli@chromium.org>
Date: Tue Dec 06 20:43:48 2016

Standardize "net" category trace events

Some "net" trace events are logged with "disabled-by-default-" prefix and
some are not. This CL tries to Standardize the usage.

BUG= 669918 

Review-Url: https://codereview.chromium.org/2533953005
Cr-Commit-Position: refs/heads/master@{#436706}

[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/BUILD.gn
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/base/network_delegate.cc
[add] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/base/trace_constants.cc
[add] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/base/trace_constants.h
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/cert/crl_set_storage.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/cert/multi_threaded_cert_verifier.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/disk_cache/blockfile/in_flight_io.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/dns/host_cache.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/dns/host_resolver_impl.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/http/http_cache_transaction.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/http/http_stream_factory_impl_job.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/proxy/proxy_resolver_v8_tracing.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/socket/client_socket_handle.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/socket/client_socket_pool_base.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/socket/socket_posix.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/socket/ssl_client_socket_pool.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/socket/transport_client_socket_pool.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/socket/udp_socket_posix.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/socket/websocket_transport_client_socket_pool.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/spdy/spdy_session_pool.cc
[modify] https://crrev.com/0b7f5b65efc8cfd59c04619e92a052dc2a0a965f/net/url_request/url_request_http_job.cc

Comment 4 by xunji...@chromium.org, Dec 6 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment